Page MenuHomePhabricator
Differential D9545

[web] Fix thread creation from media
ClosedPublic
Actions

Authored by ashoat on Oct 19 2023, 1:15 PM.
Tags
None
Referenced Files
F6137395: D9545.id.diff
Tue, Apr 22, 6:01 AM
F6133513: D9545.id32231.diff
Tue, Apr 22, 4:36 AM
F6130139: D9545.id32273.diff
Tue, Apr 22, 12:58 AM
Unknown Object (File)
Mon, Apr 21, 2:40 PM
Unknown Object (File)
Mar 5 2025, 1:31 AM
Unknown Object (File)
Feb 20 2025, 8:07 PM
Unknown Object (File)
Feb 2 2025, 12:16 PM
Unknown Object (File)
Jan 27 2025, 1:57 AM
View All Files
Subscribers
will

Details

Reviewers
bartek
atul
tomek
Commits
rCOMMea70657bd6b7: [web] Fix thread creation from media
Summary

This solves ENG-5145, a regression introduced in D7434.

The issue is that pending threads don't appear in the ThreadStore. Instead of trying to pull the ThreadInfo from the ThreadStore, we should drill it through from the callsites.

Test Plan

I confirmed that I'm again able to create a thread from media in my local environment (the bug no longer repros)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 32273

View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/chat-message-list-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...