Page MenuHomePhabricator

[native] implement deleteUser native client method and expose it via CommRustModule
ClosedPublic

Authored by varun on Oct 20 2023, 9:00 AM.
Tags
None
Referenced Files
F2745148: D9555.diff
Wed, Sep 18, 5:16 AM
Unknown Object (File)
Sat, Sep 14, 6:34 PM
Unknown Object (File)
Sat, Sep 14, 6:34 PM
Unknown Object (File)
Sat, Sep 14, 6:33 PM
Unknown Object (File)
Sat, Sep 14, 6:28 PM
Unknown Object (File)
Sat, Sep 7, 10:37 AM
Unknown Object (File)
Sat, Sep 7, 2:40 AM
Unknown Object (File)
Aug 14 2024, 5:44 PM
Subscribers

Details

Summary

this is pretty similar to the updatePassword method. we just send the standard auth info (access token, user ID, device ID). since it's available in the comm secure store now, so we can probably refactor the JSI function in the future to not take any params. for now, though, i'm just following the pattern in updatePassword.

Test Plan

registered a new user and then called deleteUser from js and verified that the user's data was removed from my local ddb tables

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Oct 20 2023, 9:18 AM
native/native_rust_library/src/lib.rs
593 ↗(On Diff #32268)

Could you remind me - is this hardcoded address going to be replaced once we have the getCommConfig stuff implemented?

This revision is now accepted and ready to land.Oct 20 2023, 9:36 AM
native/native_rust_library/src/lib.rs
593 ↗(On Diff #32268)

yeah that's correct. this is tracked in ENG-4885