Page MenuHomePhabricator
Differential D9579

[CI] run iOS Build CI on push to CI branch
ClosedPublic
Actions

Authored by varun on Oct 24 2023, 10:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 5:47 PM
Unknown Object (File)
Thu, Nov 28, 4:04 PM
Unknown Object (File)
Oct 28 2024, 5:21 PM
Unknown Object (File)
Oct 4 2024, 2:00 AM
Unknown Object (File)
Oct 4 2024, 2:00 AM
Unknown Object (File)
Oct 4 2024, 2:00 AM
Unknown Object (File)
Oct 4 2024, 2:00 AM
Unknown Object (File)
Oct 4 2024, 1:58 AM
View All 58 Files
Subscribers
tomek
will

Details

Reviewers
ashoat
atul
Commits
rCOMM433111dbf806: [CI] run iOS Build CI on push to CI branch
Summary

I think this might let us avoid forking the repo to investigate CI issues. If the push event is to the CI branch, a tmate session will be set up.

Test Plan

will test this by pushing to CI branch on GitHub and seeing if iOS Build CI runs

Diff Detail

Repository
rCOMM Comm
Branch
CI (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 24 2023, 10:50 AM
Herald added subscribers: will, tomek. · View Herald TranscriptOct 24 2023, 10:50 AM
varun published this revision for review.Oct 24 2023, 10:54 AM
ashoat added a comment.Oct 24 2023, 10:55 AM

Haven't you already forked? What's the benefit of avoiding already-complete work?

varun added a comment.Oct 24 2023, 10:57 AM
In D9579#280707, @ashoat wrote:

Haven't you already forked? What's the benefit of avoiding already-complete work?

this is so that if anyone else encounters an issue, they won't need to fork

Harbormaster completed remote builds in B23449: Diff 32349.Oct 24 2023, 11:09 AM
ashoat added a comment.Oct 24 2023, 11:12 AM

One challenge here is going to be that if eg. the Android CI pipeline is filing, then the person debugging will have to update the Android CI job.

We could enable this for every single CI job, but that probably wouldn't be great because the runners would get saturated running jobs that aren't being investigated.

Maybe we add this for every job, but have a different branch name for each job?

Curious for @atul's take as well.

atul accepted this revision.Oct 24 2023, 4:07 PM

Instead of special casing a CI branch, let's do something like CI-* that includes any branch with a CI-* prefix. This will allow eg two people to diagnose separate CI issues at the same time

Agree w/ @ashoat's feedback.

WRT

Maybe we add this for every job, but have a different branch name for each job?

We could maybe group by native/web/services or something like that to reduce CI load without having to have such a high resolution?

This revision is now accepted and ready to land.Oct 24 2023, 4:07 PM
ashoat added a comment.Oct 25 2023, 7:30 AM

Wouldn't we NOT want CI-* then?

.github/workflows/ios_ci.yml
5

Should this be debugci/ios or something instead?

varun updated this revision to Diff 32408.Oct 25 2023, 9:53 AM

makes sense to use a wildcard so that people can investigate CI issues in multiple branches

varun added a comment.Oct 25 2023, 9:59 AM
In D9579#281158, @ashoat wrote:

Wouldn't we NOT want CI-* then?

addressed your inline feedback but not really sure what you meant here. we can discuss during the CI sync

This revision was landed with ongoing or failed builds.Oct 25 2023, 9:59 AM
Closed by commit rCOMM433111dbf806: [CI] run iOS Build CI on push to CI branch (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM433111dbf806: [CI] run iOS Build CI on push to CI branch.
Harbormaster completed remote builds in B23495: Diff 32408.Oct 25 2023, 10:19 AM

Revision Contents
Changeset List

PathSize
.github/
workflows/
6 lines

Diff 32349

View Options

.github/workflows/ios_ci.yml

Loading...