Paths

Table of Contentst

Differential D9604

[web] fix user profile long username bug
ClosedPublic
Actions

Authored by ginsu on Oct 25 2023, 8:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 14, 7:48 PM

	Unknown Object (File)
	Thu, Nov 14, 7:40 PM

	Unknown Object (File)
	Thu, Nov 14, 5:12 PM

	Unknown Object (File)
	Wed, Nov 13, 1:24 PM

	Unknown Object (File)
	Wed, Nov 13, 1:24 PM

	Unknown Object (File)
	Wed, Nov 13, 1:24 PM

	Unknown Object (File)
	Wed, Nov 13, 1:23 PM

	Unknown Object (File)
	Wed, Nov 13, 1:20 PM

View All 69 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM10bd397d84d4: [web] fix user profile long username bug

Summary

This diff fixes the bug where we had text overflow with longer usernames. To address this I introduced a version of SingleLine for web.

For context here is the native version of SingleLine
https://github.com/CommE2E/comm/blob/master/native/components/single-line.react.js

Linear task: https://linear.app/comm/issue/ENG-5372/fix-user-profiles-for-long-usernames

Test Plan

Please see screenshots below

Before:

Screenshot 2023-10-25 at 11.17.54 PM.png (1×3 px, 663 KB)

after:

Screenshot 2023-10-25 at 11.24.46 PM.png (1×3 px, 660 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 25 2023, 8:28 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 25 2023, 8:28 PM

ginsu edited the summary of this revision. (Show Details)Oct 25 2023, 8:31 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu attached a referenced file: F837886: Screenshot 2023-10-25 at 11.24.46 PM.png. (Show Details)

ginsu attached a referenced file: F837885: Screenshot 2023-10-25 at 11.17.54 PM.png. (Show Details)

Harbormaster completed remote builds in B23502: Diff 32418.Oct 25 2023, 8:46 PM

ginsu requested review of this revision.Oct 25 2023, 8:46 PM

atul accepted this revision.Oct 26 2023, 9:54 AM

atul added a subscriber: • ted.

atul added inline comments.

web/components/single-line.react.js
11 ↗	(On Diff #32418)	Calling this `children` is a little weird? I'd maybe expect a `React.Node` or something. We could just call it `text` or something along those lines?
22 ↗	(On Diff #32418)	Thoughts on making this like <div title={children} className={singleLineClassName}>{text}</div> so user can see full username on hover? CC @ashoat/@ted since I guess this is kind of a design decision

This revision is now accepted and ready to land.Oct 26 2023, 9:54 AM

ginsu added inline comments.Oct 26 2023, 11:29 AM

web/components/single-line.react.js
11 ↗	(On Diff #32418)	Spoke to @atul IRL and we decided to just keep it the same so that both `SingleLine` components in native and web have the same api
22 ↗	(On Diff #32418)	Not sure if I am a big fan of this. Going to land this for now, but if this is a feature that we want I will create a follow up Linear task for it

rebase before landing

This revision was landed with ongoing or failed builds.Oct 26 2023, 11:31 AM

Closed by commit rCOMM10bd397d84d4: [web] fix user profile long username bug (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM10bd397d84d4: [web] fix user profile long username bug.

Harbormaster completed remote builds in B23521: Diff 32441.Oct 26 2023, 11:49 AM

Revision Contents
Changeset List

Path

Size

web/

components/

single-line.css

5 lines

single-line.react.js

25 lines

modals/

user-profile/

user-profile.css

3 lines

user-profile.react.js

3 lines

Diff 32442

web/components/single-line.css

Loading...

web/components/single-line.react.js

Loading...

web/modals/user-profile/user-profile.css

Loading...

web/modals/user-profile/user-profile.react.js

Loading...