web/flow-typed/npm/grpc-web_v1.x.x.js
54–66 ↗	(On Diff #32601)	i carried over the 3 `any` types above from the reference TypeScript declaration file linked in the summary. i also changed the `unknown` types from the reference file to `mixed`.

varun requested review of this revision.Nov 1 2023, 5:17 PM

remove the read-only aspect of the Metadata type

If you want to keep the change to Metadata (or disagree with any of the other comments), please re-request review

web/flow-typed/npm/grpc-web_v1.x.x.js
6 ↗	(On Diff #32602)	Let's undo this change unless you have a good reason. TypeScript isn't as robust of a typechecker as Flow... just because they can't handle read-only types doesn't mean we should follow suit. Part of the task of converting TypeScript types to Flow types is considering whether or not they should be made read-only
55 ↗	(On Diff #32602)	We should make this read-only Can we try `mixed`? It's almost certainly a better idea here
59–64 ↗	(On Diff #32602)	Nit to match JS style conventions

This revision is now accepted and ready to land.Nov 2 2023, 6:50 AM

web/flow-typed/npm/grpc-web_v1.x.x.js
6 ↗	(On Diff #32602)	Never mind, it's clear in D9672 that this needs to be mutable. Would be good to explain that change in this diff to save me some typing next time