added the relevant types using this file as reference: https://github.com/grpc/grpc-web/blob/master/packages/grpc-web/index.d.ts
Depends on D9670
Details
Details
- Reviewers
ashoat - Commits
- rCOMMd62b1f96e94e: [web] add flow types for grpc-web unary interceptor
ran flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- grpc-web (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/flow-typed/npm/grpc-web_v1.x.x.js | ||
|---|---|---|
| 54–66 | i carried over the 3 any types above from the reference TypeScript declaration file linked in the summary. i also changed the unknown types from the reference file to mixed. | |
Comment Actions
If you want to keep the change to Metadata (or disagree with any of the other comments), please re-request review
| web/flow-typed/npm/grpc-web_v1.x.x.js | ||
|---|---|---|
| 6 ↗ | (On Diff #32602) | Let's undo this change unless you have a good reason. TypeScript isn't as robust of a typechecker as Flow... just because they can't handle read-only types doesn't mean we should follow suit. Part of the task of converting TypeScript types to Flow types is considering whether or not they should be made read-only |
| 55 ↗ | (On Diff #32602) |
|
| 59–64 ↗ | (On Diff #32602) | Nit to match JS style conventions |