[lib] Introduce `invertObjectToMap`
ClosedPublic
Actions

Authored by atul on Nov 2 2023, 11:40 AM.

Details

Reviewers

ashoat
tomek
ginsu
rohan

Commits

rCOMM7483cae752b2: [lib] Introduce `invertObjectToMap`

Summary

Context: https://linear.app/comm/issue/ENG-5640/consider-introducing-invertobjecttomap-utility-fn

Thanks @tomek for investigating + resolving the flow issues with this utility!

Test Plan

Consumed in minimally-encoded-thread-permissions, where the unit tests continue to succeed.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 2 2023, 11:40 AM

Herald added a subscriber: will. · View Herald TranscriptNov 2 2023, 11:40 AM

Harbormaster completed remote builds in B23685: Diff 32639.Nov 2 2023, 12:05 PM

atul requested review of this revision.Nov 2 2023, 12:05 PM

ashoat accepted this revision.Nov 2 2023, 12:12 PM

ashoat added inline comments.

lib/utils/objects.js
132 ↗	(On Diff #32639)	Let's mark the input as read-only so the caller doesn't have to worry about us mutating it (Output is fine as-is though)

This revision is now accepted and ready to land.Nov 2 2023, 12:12 PM

address feedback

This revision was landed with ongoing or failed builds.Nov 2 2023, 6:10 PM

Closed by commit rCOMM7483cae752b2: [lib] Introduce `invertObjectToMap` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7483cae752b2: [lib] Introduce `invertObjectToMap`.

Harbormaster completed remote builds in B23696: Diff 32652.Nov 2 2023, 6:27 PM

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-thread-permissions.js

21 lines

utils/

objects.js

9 lines

Diff 32653

View Options

lib/permissions/minimally-encoded-thread-permissions.js