Paths

Table of Contentst

Differential D9682

[lib] remove asserting if `messageStore.threads` are equal
ClosedPublic
Actions

Authored by kamil on Nov 3 2023, 6:45 AM.

Tags

None

Referenced Files

	F2189437: D9682.id32896.diff
	Thu, Jul 4, 10:46 AM

	Unknown Object (File)
	Tue, Jul 2, 9:21 AM

	Unknown Object (File)
	Sun, Jun 23, 11:15 AM

	Unknown Object (File)
	Fri, Jun 14, 7:17 AM

	Unknown Object (File)
	Mon, Jun 10, 5:41 PM

	Unknown Object (File)
	May 21 2024, 1:59 AM

	Unknown Object (File)
	May 21 2024, 1:59 AM

	Unknown Object (File)
	May 21 2024, 1:59 AM

View All 34 Files

Subscribers

Details

Reviewers

Commits

rCOMM3b4fe614ca95: [lib] remove asserting if `messageStore.threads` are equal

Summary

This code was live for a long time and recently there were no issues, so I think we can remove it and rely on threads data processed by ops.

Test Plan

N/A, it's hard to test as code I am removing was responsible for testing.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 3 2023, 6:45 AM

kamil held this revision as a draft.

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 3 2023, 6:45 AM

kamil added a child revision: D9683: [native] stop persisting `messageStore.threads` via redux-persist.Nov 3 2023, 6:49 AM

kamil published this revision for review.Nov 3 2023, 6:59 AM

Harbormaster completed remote builds in B23714: Diff 32673.Nov 3 2023, 7:04 AM

atul accepted this revision.Nov 3 2023, 11:30 AM

atul added inline comments.

lib/reducers/message-reducer.js
145 ↗	(On Diff #32673)	Not a huge deal, but noticed a couple of these changes throughout diff. Don't mind either way, but curious if intentional or if automatic via Prettier or something?

This revision is now accepted and ready to land.Nov 3 2023, 11:30 AM

atul mentioned this in D9683: [native] stop persisting `messageStore.threads` via redux-persist.Nov 3 2023, 11:33 AM

remove blank lines

This revision was landed with ongoing or failed builds.Nov 8 2023, 3:42 AM

Closed by commit rCOMM3b4fe614ca95: [lib] remove asserting if `messageStore.threads` are equal (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3b4fe614ca95: [lib] remove asserting if `messageStore.threads` are equal.

kamil mentioned this in D9759: [native] cleanup SQLite handler code.Nov 8 2023, 3:54 AM

Harbormaster completed remote builds in B23868: Diff 32896.Nov 8 2023, 6:50 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

183 lines

message-reducer.test.js

14 lines

Diff 32933

lib/reducers/message-reducer.js

Loading...

lib/reducers/message-reducer.test.js

Loading...