Page MenuHomePhabricator
Differential D9824

Reset badgeCount during log out
ClosedPublic
Actions

Authored by marcin on Nov 10 2023, 9:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 12:50 AM
Unknown Object (File)
Sat, Mar 1, 5:28 AM
Unknown Object (File)
Sat, Mar 1, 5:28 AM
Unknown Object (File)
Sat, Mar 1, 5:28 AM
Unknown Object (File)
Sat, Mar 1, 5:28 AM
Unknown Object (File)
Sat, Mar 1, 5:15 AM
Unknown Object (File)
Sat, Mar 1, 4:19 AM
Unknown Object (File)
Jan 24 2025, 11:54 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
tomek
atul
Commits
rCOMM5ca72bdf9779: Reset badgeCount during log out
Summary

This differential fixes badge count behaviour during log-out. The context is here:
https://linear.app/comm/issue/ENG-5169/badge-count-is-not-reset-when-logging-out.

Test Plan

Before this diff:

  1. Update badge count of app (mark some threads as unread on web)
  2. Log out
  3. Ensure badge count remains unchanged.

After this diff:

  1. Update badge count of app (mark some threads as unread on web)
  2. Log out
  3. Ensure badge count is cleared.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Nov 10 2023, 9:14 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 9:14 AM
marcin added reviewers: tomek, atul.Nov 10 2023, 9:15 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 10 2023, 9:31 AM
Harbormaster failed remote builds in B24000: Diff 33074!
marcin updated this revision to Diff 33110.Nov 13 2023, 2:21 AM

Fix invalid Android method name

Harbormaster completed remote builds in B24027: Diff 33110.Nov 13 2023, 2:41 AM
marcin requested review of this revision.Nov 13 2023, 2:41 AM
atul accepted this revision.Nov 13 2023, 9:26 AM
This revision is now accepted and ready to land.Nov 13 2023, 9:26 AM
marcin updated this revision to Diff 33130.Nov 13 2023, 9:43 AM

Rebase before landing

Harbormaster completed remote builds in B24044: Diff 33130.Nov 13 2023, 10:06 AM
Closed by commit rCOMM5ca72bdf9779: Reset badgeCount during log out (authored by marcin). · Explain WhyNov 13 2023, 10:08 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM5ca72bdf9779: Reset badgeCount during log out.

Revision Contents
Changeset List

PathSize
native/
push/
9 lines

Diff 33132

View Options

native/push/push-handler.react.js

Show All 20 Lines
async function preloadImage(uri: string): Promise<{ async function preloadImage(uri: string): Promise<{
steps: $ReadOnlyArray<MediaMissionStep>, steps: $ReadOnlyArray<MediaMissionStep>,
result: ?Image, result: ?Image,
}> { }> {
let image, exceptionMessage; let image, exceptionMessage;
const start = Date.now(); const start = Date.now();
const imageURI = fetchableMediaURI(uri); const imageURI = fetchableMediaURI(uri);
try { try {
image = await new Promise((resolve, reject) => { image = await new Promise<Image>((resolve, reject) => {
const img = new Image(); const img = new Image();
img.src = imageURI; img.src = imageURI;
img.onload = () => { img.onload = () => {
resolve(img); resolve(img);
}; };
img.onerror = e => { img.onerror = e => {
reject(e); reject(e);
}; };
▲ Show 20 Lines • Show All 129 Lines • ▼ Show 20 Lines if (orientation === 2) {
context.transform(0, -1, -1, 0, dimensions.width, dimensions.height); context.transform(0, -1, -1, 0, dimensions.width, dimensions.height);
} else if (orientation === 8) { } else if (orientation === 8) {
context.transform(0, -1, 1, 0, 0, dimensions.height); context.transform(0, -1, 1, 0, 0, dimensions.height);
} else { } else {
context.transform(1, 0, 0, 1, 0, 0); context.transform(1, 0, 0, 1, 0, 0);
} }
context.drawImage(image, 0, 0); context.drawImage(image, 0, 0);
reorientedBlob = await new Promise(resolve => reorientedBlob = await new Promise<Blob>(resolve =>
canvas.toBlob(blobResult => resolve(blobResult)), canvas.toBlob(blobResult => resolve(blobResult)),
); );
} catch (e) { } catch (e) {
reorientExceptionMessage = getMessageForException(e); reorientExceptionMessage = getMessageForException(e);
} }
URL.revokeObjectURL(initialURI); URL.revokeObjectURL(initialURI);
const uri = reorientedBlob && URL.createObjectURL(reorientedBlob); const uri = reorientedBlob && URL.createObjectURL(reorientedBlob);
steps.push({ steps.push({
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines