Differential D9824

Reset badgeCount during log out
ClosedPublic
Actions

Authored by marcin on Nov 10 2023, 9:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 9, 12:50 AM

	Unknown Object (File)
	Mar 1 2025, 5:28 AM

	Unknown Object (File)
	Mar 1 2025, 5:28 AM

	Unknown Object (File)
	Mar 1 2025, 5:28 AM

	Unknown Object (File)
	Mar 1 2025, 5:28 AM

	Unknown Object (File)
	Mar 1 2025, 5:15 AM

	Unknown Object (File)
	Mar 1 2025, 4:19 AM

	Unknown Object (File)
	Jan 24 2025, 11:54 PM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMM5ca72bdf9779: Reset badgeCount during log out

Summary

This differential fixes badge count behaviour during log-out. The context is here:
https://linear.app/comm/issue/ENG-5169/badge-count-is-not-reset-when-logging-out.

Test Plan

Before this diff:

Update badge count of app (mark some threads as unread on web)
Log out
Ensure badge count remains unchanged.

After this diff:

Update badge count of app (mark some threads as unread on web)
Log out
Ensure badge count is cleared.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Nov 10 2023, 9:14 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 9:14 AM

marcin added reviewers: tomek, atul.Nov 10 2023, 9:15 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 10 2023, 9:31 AM

Harbormaster failed remote builds in B24000: Diff 33074!

Fix invalid Android method name

Harbormaster completed remote builds in B24027: Diff 33110.Nov 13 2023, 2:41 AM

marcin requested review of this revision.Nov 13 2023, 2:41 AM

atul accepted this revision.Nov 13 2023, 9:26 AM

This revision is now accepted and ready to land.Nov 13 2023, 9:26 AM

Rebase before landing

Harbormaster completed remote builds in B24044: Diff 33130.Nov 13 2023, 10:06 AM

Closed by commit rCOMM5ca72bdf9779: Reset badgeCount during log out (authored by marcin). · Explain WhyNov 13 2023, 10:08 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM5ca72bdf9779: Reset badgeCount during log out.

Revision Contents
Changeset List

Path

Size

native/

push/

push-handler.react.js

9 lines

Diff 33132

native/push/push-handler.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };