[lib] Update `threadHasPermission` to "go through" `permissionLookup`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 1:03 PM.

Details

Reviewers

ashoat
ginsu
rohan
tomek

Commits

rCOMM561705347d2c: [lib] Update `threadHasPermission` to "go through" `permissionLookup`

Summary

Update threadHasPermission to "go through" permissionLookup for checking permissions rather than indexing into threadInfo.currentUser.permission directly.
This ensures that behavior of threadHasPermission matches permissionLookup. Specifically, to ensure that the KNOW_OF permission is also true in addition to whatever permission is being checked. This will also ensure that in the future we only need to add conditions in "one place."

Depends on D9844

Test Plan

Close reading/flow, don't think we need a unit test for this...

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 13 2023, 1:03 PM

atul published this revision for review.Nov 13 2023, 1:04 PM

atul added inline comments.

lib/shared/thread-utils.js
135–137 ↗	(On Diff #33147)	This case is handled within `permissionLookup` so removing duplicate logic (even though I guess it would "short circuit" a function call).