Page MenuHomePhabricator
Differential D9925

[native] Rust futures in C++
Needs RevisionPublic
Actions

Authored by michal on Fri, Nov 17, 9:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 2, 8:03 AM
Unknown Object (File)
Sat, Dec 2, 7:09 AM
Unknown Object (File)
Mon, Nov 27, 8:21 AM
Unknown Object (File)
Fri, Nov 17, 5:22 PM
Subscribers
ashoat
tomek

Details

Reviewers
kamil
marcin
varun
Summary

Similar to the existing RustPromiseManager but for the promises created on Rust side and resolved on the C++ side. Will be used for async Secure Store access ENG-5700.

Test Plan

Run the provided test.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Fri, Nov 17, 9:20 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Nov 17, 9:20 AM
michal added a child revision: D9926: [native] Expose SecureStore to Rust.Fri, Nov 17, 9:47 AM
Harbormaster completed remote builds in B24252: Diff 33390.Fri, Nov 17, 10:07 AM
michal requested review of this revision.Fri, Nov 17, 10:07 AM
marcin added inline comments.Mon, Nov 20, 2:42 AM
native/native_rust_library/src/cxx_promise_manager.rs
5

This will require to create new global hash map every time we introduce new type that some promie will resolve to. In every programming language that I know this could be resolved without having to add new hash map for each type.

Is it the limitation of CXX that forces this approach?

varun requested changes to this revision.Mon, Nov 20, 10:27 AM
varun added inline comments.
native/native_rust_library/src/cxx_promise_manager.rs
1–69
This revision now requires changes to proceed.Mon, Nov 20, 10:27 AM

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
69 lines
2 lines

Diff 33390

View Options

native/native_rust_library/src/cxx_promise_manager.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...