Page MenuHomePhabricator

[native] Rust futures in C++
AbandonedPublic

Authored by michal on Nov 17 2023, 9:20 AM.
Tags
None
Referenced Files
F2087339: D9925.id.diff
Sun, Jun 23, 2:46 PM
F2084304: D9925.id33390.diff
Sun, Jun 23, 5:21 AM
Unknown Object (File)
Tue, Jun 18, 6:49 AM
Unknown Object (File)
Thu, Jun 13, 6:11 AM
Unknown Object (File)
May 23 2024, 7:02 AM
Unknown Object (File)
May 21 2024, 1:19 PM
Unknown Object (File)
May 21 2024, 1:14 PM
Unknown Object (File)
May 10 2024, 7:02 PM
Subscribers

Details

Reviewers
kamil
marcin
varun
Summary

Similar to the existing RustPromiseManager but for the promises created on Rust side and resolved on the C++ side. Will be used for async Secure Store access ENG-5700.

Test Plan

Run the provided test.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/native_rust_library/src/cxx_promise_manager.rs
5

This will require to create new global hash map every time we introduce new type that some promie will resolve to. In every programming language that I know this could be resolved without having to add new hash map for each type.

Is it the limitation of CXX that forces this approach?

varun requested changes to this revision.Nov 20 2023, 10:27 AM
varun added inline comments.
native/native_rust_library/src/cxx_promise_manager.rs
1–69
This revision now requires changes to proceed.Nov 20 2023, 10:27 AM

Abandoning as it is an old diff. Something similar to this has been implemented in D10858