This is similar to fixUnreadActiveThread on native.
Also moving processing ops to the end of reducer executions.
Depends on D9955
Details
Details
- Reviewers
tomek michal - Commits
- rCOMMcd336bec1635: [web] refactor validateState to operations
- Unread/read status works.
- Processing ops works.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/redux/redux-setup.js | ||
|---|---|---|
| 314–327 ↗ | (On Diff #33516) | Should we check if it is unread before pushing the op? Currently, it seems like we're going to create a new op every time we validate a state, which sounds wasteful. |
| 365 ↗ | (On Diff #33516) | It doesn't sound like this call should be a part of the validate function. Maybe we can rename some functions or introduce new ones so that this processing isn't in a surprising place? |
| web/redux/redux-setup.js | ||
|---|---|---|
| 314–327 ↗ | (On Diff #33516) | Doesn't line 311 perform this check? Or am I missing something? |
| web/redux/redux-setup.js | ||
|---|---|---|
| 314–327 ↗ | (On Diff #33516) | Ah, yes, that makes sense! |
Comment Actions
rename
| web/redux/redux-setup.js | ||
|---|---|---|
| 365 ↗ | (On Diff #33516) | I think the cleanest will be to rename validateState -> validateStateAndProcessDBOperations |