We need to introduce something that emulates pointers in C++ because of Emscripten limitations.
Context here: ENG-5719
Paths
| Differential D9902 Authored by kamil on Nov 15 2023, 12:17 PM.
Details
Summary We need to introduce something that emulates pointers in C++ because of Emscripten limitations. Context here: ENG-5719 Test Plan
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added a subscriber: ashoat. ยท View Herald TranscriptNov 15 2023, 12:17 PM2023-11-15 12:17:35 (UTC-8) kamil added a child revision: D9903: [SQLite] add table for users.Nov 15 2023, 12:23 PM2023-11-15 12:23:02 (UTC-8) Harbormaster completed remote builds in B24172: Diff 33290.Nov 15 2023, 2:06 PM2023-11-15 14:06:56 (UTC-8) kamil removed a child revision: D9903: [SQLite] add table for users.Nov 16 2023, 6:10 AM2023-11-16 06:10:05 (UTC-8) kamil retitled this revision from [SQLite] introduce NullableString to [SQLite] introduce Nullable entity.Nov 22 2023, 3:36 AM2023-11-22 03:36:11 (UTC-8) Harbormaster completed remote builds in B24324: Diff 33480.Nov 22 2023, 3:54 AM2023-11-22 03:54:16 (UTC-8) marcin added inline comments.
This revision now requires changes to proceed.Nov 22 2023, 5:25 AM2023-11-22 05:25:11 (UTC-8) Comment Actions
Yes, I did. There is no support for std::optional yet, but I found an issue on Emsctipen link and PR link. I tried solutions suggested there but two things:
kamil added inline comments.
This revision is now accepted and ready to land.Nov 27 2023, 4:49 AM2023-11-27 04:49:49 (UTC-8) Closed by commit rCOMM2997dfb0474f: [SQLite] introduce Nullable entity (authored by kamil). ยท Explain WhyNov 27 2023, 6:47 AM2023-11-27 06:47:36 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33730 native/cpp/CommonCpp/DatabaseManagers/entities/Nullable.h
web/cpp/SQLiteQueryExecutorBindings.cpp
web/database/_generated/comm-query-executor.js
web/database/_generated/comm_query_executor.wasm
web/database/types/entities.js
|