[landing] Give the social icons a little more room at lower breakpoints
ClosedPublic
Actions

Authored by atul on Mar 10 2022, 1:35 PM.

Details

Reviewers

tomek
• jacek
varun
• benschac
ashoat

Commits

rCOMMb2c12b8514bc: [landing] Give the social icons a little more room at lower breakpoints

Summary

Noticed that the social icons were a little crammed at the smaller breakpoints. Just fixing this up really quick before bringing back their hover state.

Test Plan

Here's how it looks on iPhone 13 mini:

Simulator Screen Shot - iPhone 13 mini - 2022-03-10 at 16.35.03.png (2×1 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 10 2022, 1:35 PM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 10 2022, 1:35 PM

atul edited the test plan for this revision. (Show Details)Mar 10 2022, 1:35 PM

Harbormaster completed remote builds in B7291: Diff 10281.Mar 10 2022, 1:45 PM

atul requested review of this revision.Mar 10 2022, 1:45 PM

also cut space-between and give icons fixed distance between each other

Harbormaster completed remote builds in B7293: Diff 10283.Mar 10 2022, 2:04 PM

atul mentioned this in D3390: [landing] Add "launch app" icon to `Header`.Mar 10 2022, 9:50 PM

tomek accepted this revision.Mar 11 2022, 5:36 AM

This revision is now accepted and ready to land.Mar 11 2022, 5:36 AM

Can you share a screenshot for desktop, following the concern I raised in D3390?

This revision now requires changes to proceed.Mar 11 2022, 7:21 AM

Can you share a screenshot for desktop, following the concern I raised in D3390? (@ashoat)

Looks great!

This revision is now accepted and ready to land.Mar 14 2022, 9:22 PM

rebase before landing

Harbormaster failed remote builds in B7402: Diff 10421!Mar 15 2022, 3:12 PM

This revision was landed with ongoing or failed builds.Mar 15 2022, 3:21 PM

Closed by commit rCOMMb2c12b8514bc: [landing] Give the social icons a little more room at lower breakpoints (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb2c12b8514bc: [landing] Give the social icons a little more room at lower breakpoints.

Revision Contents
Changeset List

Path

Size

landing/

header.css

4 lines

Diff 10281

View Options

[landing] Give the social icons a little more room at lower breakpointsClosedPublicActions