Paths

Table of Contentst

Differential D3420

[services] Add comments about indexes
ClosedPublic
Actions

Authored by • karol on Mar 14 2022, 8:50 AM.

Tags

None

Referenced Files

	F3540104: D3420.id10335.diff
	Thu, Dec 26, 4:28 AM

	F3540099: D3420.id10555.diff
	Thu, Dec 26, 4:25 AM

	F3539964: D3420.id10587.diff
	Thu, Dec 26, 4:04 AM

	F3535702: D3420.diff
	Wed, Dec 25, 4:51 PM

	Unknown Object (File)
	Fri, Dec 20, 6:35 PM

	Unknown Object (File)
	Fri, Dec 20, 6:35 PM

	Unknown Object (File)
	Fri, Dec 20, 6:35 PM

	Unknown Object (File)
	Fri, Dec 20, 6:35 PM

Subscribers

Details

Reviewers

tomek
varun
atul
• max
• jim
ashoat

Commits

rCOMM82073b570fb5: [services] Add comments about indexes

Summary

Raised here https://phabricator.ashoat.com/D3087#86770

Adding comments in places where database indexes are needed.

Test Plan

None, these are just comments

Diff Detail

Repository

Branch

backup-follow-up

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 14 2022, 8:50 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 14 2022, 8:50 AM

• karol edited the summary of this revision. (Show Details)Mar 14 2022, 8:51 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, atul, • max, • jim.

• karol mentioned this in D3087: [services] Backup - Database - add Backup Item.

Harbormaster completed remote builds in B7334: Diff 10335.Mar 14 2022, 8:55 AM

• karol requested review of this revision.Mar 14 2022, 8:55 AM

ashoat requested changes to this revision.Mar 14 2022, 11:12 AM

ashoat added inline comments.

services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h
13–17	My initial request was: [comment] clarifying that this class is used for representing two things: the rows in the main table, and also the rows in the secondary index This comment doesn't seem to provide that clarification. Is my understanding correcrt, that `BackupItem` is used for representing both rows in the main table, as well as rows in the secondary index? If so, can you add a comment making that clear?

This revision now requires changes to proceed.Mar 14 2022, 11:12 AM

fix comment

Harbormaster completed remote builds in B7499: Diff 10555.Mar 21 2022, 3:50 AM

ashoat accepted this revision.Mar 21 2022, 7:23 AM

This revision is now accepted and ready to land.Mar 21 2022, 7:23 AM

Closed by commit rCOMM82073b570fb5: [services] Add comments about indexes (authored by • karol). · Explain WhyMar 22 2022, 1:40 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM82073b570fb5: [services] Add comments about indexes.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseEntities/

7 lines

blob/

docker-server/

contents/

server/

src/

DatabaseEntities/

ReverseIndexItem.h

5 lines

Diff 10335

services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h

Loading...

services/blob/docker-server/contents/server/src/DatabaseEntities/ReverseIndexItem.h

Loading...