Paths

Table of Contentst

Differential D3427

[misc] Introduce `.editorconfig`
ClosedPublic
Actions

Authored by atul on Mar 14 2022, 1:39 PM.

Tags

None

Referenced Files

	F3114764: D3427.id10382.diff
	Thu, Oct 31, 8:34 PM

	F3113851: D3427.id10367.diff
	Thu, Oct 31, 7:38 PM

	F3112148: D3427.diff
	Thu, Oct 31, 4:54 PM

	Unknown Object (File)
	Sun, Oct 27, 5:28 AM

	Unknown Object (File)
	Sun, Oct 27, 5:28 AM

	Unknown Object (File)
	Sun, Oct 27, 5:28 AM

	Unknown Object (File)
	Sun, Oct 27, 5:28 AM

	Unknown Object (File)
	Sun, Oct 27, 5:28 AM

Subscribers

Details

Reviewers

• jim
ashoat
tomek
• jacek
varun
• benschac

Commits

rCOMM6f7a084f3615: [misc] Introduce `.editorconfig`

Summary

Set default indent style to space with default indent size of 2

(Additional rules can be put up as separate diffs)

Worked with VSCode after installing EditorConfig extension: https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig

It looks like the nano/vim/emacs people will need to install some plugins to get it to work for them

Test Plan

Here it is working in VSCode (did a python file so existing eslint/prettier/whatever config wouldn't interfere)

Diff Detail

Repository

Branch

landmarch14 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 14 2022, 1:39 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 14 2022, 1:39 PM

newline end of file

atul published this revision for review.Mar 14 2022, 1:42 PM

atul edited the summary of this revision. (Show Details)

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B7363: Diff 10367.Mar 14 2022, 1:43 PM

fix

Harbormaster completed remote builds in B7364: Diff 10368.Mar 14 2022, 1:46 PM

Harbormaster failed remote builds in B7365: Diff 10369!Mar 14 2022, 1:48 PM

Harbormaster completed remote builds in B7365: Diff 10369.Mar 14 2022, 1:56 PM

atul edited the test plan for this revision. (Show Details)Mar 14 2022, 5:34 PM

ashoat accepted this revision.Mar 14 2022, 8:25 PM

This revision is now accepted and ready to land.Mar 14 2022, 8:25 PM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 15 2022, 7:31 AM

Closed by commit rCOMM6f7a084f3615: [misc] Introduce `.editorconfig` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6f7a084f3615: [misc] Introduce `.editorconfig`.

Harbormaster completed remote builds in B7374: Diff 10381.Mar 15 2022, 7:33 AM

Add a root = true at the top. From docs "root: special property that should be specified at the top of the file outside of any sections. Set to true to stop .editorconfig files search on current file."

atul mentioned this in D3438: [misc] Add `root=true` to `.editorconfig`.Mar 15 2022, 7:04 PM

atul mentioned this in rCOMMb995d9c5981b: [misc] Add `root=true` to `.editorconfig`.Mar 15 2022, 9:12 PM

Revision Contents
Changeset List

Path

Size

4 lines

Diff 10367

.editorconfig

Loading...