Page MenuHomePhabricator
Differential D3402

[landing] Get rid of `Request Access` button and related stuff
ClosedPublic
Actions

Authored by atul on Mar 10 2022, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 9:42 AM
Unknown Object (File)
Fri, Dec 27, 9:41 AM
Unknown Object (File)
Fri, Dec 27, 9:41 AM
Unknown Object (File)
Nov 30 2024, 7:14 PM
Unknown Object (File)
Nov 30 2024, 7:14 PM
Unknown Object (File)
Nov 15 2024, 6:06 AM
Unknown Object (File)
Nov 14 2024, 8:52 AM
Unknown Object (File)
Nov 14 2024, 8:52 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
• benschac
varun
Commits
rCOMMc9430b5ae9b5: [landing] Get rid of `Request Access` button and related stuff
Summary

Get rid of the RequestAccess button in Heading (where it's visible for desktop breakpoints) and in HeroContent (where it's visible for mobile breakpoints).

Also got rid of the scrollToSubscriptionForm helper function

Leaving in the Button component, even though it's not used by anything else. Seems harmless to keep around and might be helpful in the future.

Test Plan

Landing page continues to looks as expected.
Searched through repo pretty thoroughly to make sure I didn't leave behind any remnants of the button

How it looks on desktop:

d151.png (1×3 px, 4 MB)

How it looks on mobile (iPhone 13 mini):

Simulator Screen Shot - iPhone 13 mini - 2022-03-10 at 16.24.07.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Branch
landmarch152022 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 10 2022, 12:29 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 10 2022, 12:29 PM
Harbormaster completed remote builds in B7289: Diff 10278.Mar 10 2022, 12:34 PM
atul requested review of this revision.Mar 10 2022, 12:34 PM
atul edited the test plan for this revision. (Show Details)Mar 10 2022, 1:26 PM
atul mentioned this in D3394: [landing] Reintroduce hover styling for `Request Access` button.Mar 10 2022, 9:53 PM
tomek accepted this revision.Mar 11 2022, 5:35 AM
This revision is now accepted and ready to land.Mar 11 2022, 5:35 AM
atul updated this revision to Diff 10350.Mar 14 2022, 10:16 AM

rebase

Harbormaster completed remote builds in B7349: Diff 10350.Mar 14 2022, 10:25 AM
atul updated this revision to Diff 10419.Mar 15 2022, 3:05 PM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 15 2022, 3:06 PM
Closed by commit rCOMMc9430b5ae9b5: [landing] Get rid of `Request Access` button and related stuff (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc9430b5ae9b5: [landing] Get rid of `Request Access` button and related stuff.
Harbormaster failed remote builds in B7401: Diff 10419!Mar 15 2022, 3:06 PM

Revision Contents
Changeset List

Diff 10419

View Options

landing/app-landing.react.js

Loading...
View Options

landing/header.css

Loading...
View Options

landing/header.react.js

Loading...
View Options

landing/hero-content.css

Loading...
View Options

landing/hero-content.react.js

Loading...
View Options

landing/landing.react.js

Loading...