Differential D3455

[web] [fix] benjamin/eng-896-color-splotch-wrong-size-currently-40px
ClosedPublic
Actions

Authored by • benschac on Mar 17 2022, 2:51 PM.

Tags

None

Referenced Files

	F3356371: D3455.diff
	Sat, Nov 23, 6:39 PM

	Unknown Object (File)
	Fri, Nov 15, 6:06 AM

	Unknown Object (File)
	Tue, Nov 5, 1:03 AM

	Unknown Object (File)
	Oct 20 2024, 6:41 PM

	Unknown Object (File)
	Oct 10 2024, 10:57 AM

	Unknown Object (File)
	Oct 9 2024, 7:08 PM

	Unknown Object (File)
	Oct 9 2024, 7:08 PM

	Unknown Object (File)
	Oct 9 2024, 7:07 PM

Subscribers

Details

Reviewers

atul
tomek
• jacek

Commits

rCOMM7845eabcf9cb: [web] [fix] benjamin/eng-896-color-splotch-wrong-size-currently-40px

Summary

Size bar color splotch is the wrong size https://linear.app/comm/issue/ENG-896/color-splotch-wrong-size-currently-40px-should-be-42px more in linear

before:

Image 2022-03-17 at 5.48.06 PM.jpg (578×962 px, 84 KB)

after:

Image 2022-03-17 at 6.02.48 PM.jpg (634×1 px, 74 KB)

Test Plan

Make it match figma at 42px

Diff Detail

Repository

Branch

fix-side-bar

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 17 2022, 2:51 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 17 2022, 2:51 PM

• benschac added a parent revision: D3454: [web] [fix] ENG-895 Chat Thread List Menu button and time doesn't match design.Mar 17 2022, 2:51 PM

Harbormaster completed remote builds in B7456: Diff 10505.Mar 17 2022, 2:56 PM

• benschac requested review of this revision.Mar 17 2022, 2:56 PM

• benschac edited the summary of this revision. (Show Details)Mar 17 2022, 3:02 PM

• benschac added reviewers: tomek, • jacek.Mar 17 2022, 6:01 PM

tomek accepted this revision.Mar 18 2022, 4:37 AM

This revision is now accepted and ready to land.Mar 18 2022, 4:37 AM

Closed by commit rCOMM7845eabcf9cb: [web] [fix] benjamin/eng-896-color-splotch-wrong-size-currently-40px (authored by • benschac). · Explain WhyMar 18 2022, 5:48 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM7845eabcf9cb: [web] [fix] benjamin/eng-896-color-splotch-wrong-size-currently-40px.

This is not an okay diff name. @benschac, we've talked repeatedly before about how we need you to do more to explain your changes to your reviewers. You're moving backwards with these diff names

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-list.css

4 lines

Diff 10505

web/chat/chat-thread-list.css

Loading...