Page MenuHomePhabricator
Differential D3493

[web] [refactor] move props to single destructure in top of chat thread list item menu component
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 6:42 AM.
Tags
None
Referenced Files
F3393090: D3493.id10669.diff
Sat, Nov 30, 11:28 AM
F3392560: D3493.diff
Sat, Nov 30, 9:13 AM
Unknown Object (File)
Thu, Nov 14, 4:33 PM
Unknown Object (File)
Tue, Nov 5, 7:19 AM
Unknown Object (File)
Sun, Nov 3, 1:23 PM
Unknown Object (File)
Sat, Nov 2, 8:04 AM
Unknown Object (File)
Oct 23 2024, 4:48 AM
Unknown Object (File)
Oct 22 2024, 6:59 PM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
Commits
rCOMMa5cee196b7a6: [web] [refactor] move props to single destructure in top of chat thread list…
Summary

move props destructure to one place

Test Plan

N/A - shouldn't get any flow errors. Page should render normally

Diff Detail

Repository
rCOMM Comm
Branch
fix-hover-background-color
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 6:42 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 6:42 AM
• benschac added a parent revision: D3422: [web] [fix] style mark as unread.Mar 23 2022, 6:43 AM
Harbormaster completed remote builds in B7534: Diff 10603.Mar 23 2022, 6:47 AM
• benschac requested review of this revision.Mar 23 2022, 6:47 AM
• benschac added a child revision: D3499: [web] [feat] add mark as unread styles for selected and hovered states.Mar 23 2022, 8:14 AM
atul added a comment.Mar 23 2022, 9:44 AM

N/A - should get any flow error

nit: think you mean *shouldn't?

atul accepted this revision.Mar 23 2022, 9:45 AM
This revision is now accepted and ready to land.Mar 23 2022, 9:45 AM
• benschac edited the test plan for this revision. (Show Details)Mar 23 2022, 10:01 AM
In D3493#95153, @atul wrote:

N/A - should get any flow error

nit: think you mean *shouldn't?

ty

Closed by commit rCOMMa5cee196b7a6: [web] [refactor] move props to single destructure in top of chat thread list… (authored by • benschac). · Explain WhyMar 24 2022, 12:30 PM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMa5cee196b7a6: [web] [refactor] move props to single destructure in top of chat thread list….

Revision Contents
Changeset List

PathSize
web/
chat/
4 lines

Diff 10603

View Options

web/chat/chat-thread-list-item-menu.react.js

Loading...