Details

Reviewers

atul
• jacek
tomek
ashoat

Commits

rCOMM426e725ba042: [web] [refactor] simplify username logic in message preview

Summary

simplify rendering logic for username in message preview

Test Plan

username logic is the same as production. No new functionality

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 7:33 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 7:33 PM

• benschac added a parent revision: D3505: [web] [refactor] message preview styles solidified into one ternary statement.Mar 23 2022, 7:34 PM

Harbormaster completed remote builds in B7558: Diff 10629.Mar 23 2022, 7:38 PM

• benschac requested review of this revision.Mar 23 2022, 7:38 PM

make hasUserName const

remove hasUsername const

Harbormaster completed remote builds in B7560: Diff 10631.Mar 23 2022, 7:46 PM

Harbormaster completed remote builds in B7561: Diff 10632.Mar 23 2022, 7:48 PM

• benschac added a child revision: D3508: [web] [refactor] move hasUsername logic to variable.Mar 23 2022, 8:08 PM

• benschac added reviewers: • jacek, tomek.Mar 23 2022, 8:55 PM

• benschac planned changes to this revision.Mar 24 2022, 12:20 PM

• benschac added inline comments.

web/chat/message-preview.react.js
50 ↗	(On Diff #10632)	This logic is wrong.

fix logic

Harbormaster completed remote builds in B7594: Diff 10665.Mar 24 2022, 4:22 PM

ashoat accepted this revision.Mar 25 2022, 1:02 AM

ashoat added inline comments.

web/chat/message-preview.react.js
28 ↗	(On Diff #10665)	Let's move this closer to where it's used. Line 48 makes the most sense

This revision is now accepted and ready to land.Mar 25 2022, 1:02 AM

diff review

Harbormaster completed remote builds in B7608: Diff 10684.Mar 25 2022, 2:58 PM

rebase

Harbormaster completed remote builds in B7622: Diff 10704.Mar 25 2022, 5:42 PM

Closed by commit rCOMM426e725ba042: [web] [refactor] simplify username logic in message preview. · Explain WhyMar 25 2022, 5:55 PM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM426e725ba042: [web] [refactor] simplify username logic in message preview.

[web] [refactor] simplify username logic in message preview
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 10684

web/chat/message-preview.react.js

[web] [refactor] simplify username logic in message previewClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10684

web/chat/message-preview.react.js

[web] [refactor] simplify username logic in message preview
ClosedPublic
Actions

Revision Contents
Changeset List