Page MenuHomePhabricator

[web] Change `Button` component color on hover
ClosedPublic

Authored by atul on Mar 29 2022, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 2:32 AM
Unknown Object (File)
Sat, Feb 1, 2:32 AM
Unknown Object (File)
Thu, Jan 30, 10:38 AM
Unknown Object (File)
Thu, Jan 30, 10:38 AM
Unknown Object (File)
Thu, Jan 30, 10:38 AM
Unknown Object (File)
Thu, Jan 30, 8:49 AM
Unknown Object (File)
Wed, Jan 29, 4:20 AM
Unknown Object (File)
Mon, Jan 20, 6:54 AM

Details

Summary

I looked through Figma and couldn't find any buttons in the "hover" state... but I still think buttons should change color on hover and it feels unnatural when they don't.

The button background was --violet-dark-100, so I went with --violet-dark-80 for background color on hover for now

Test Plan

Looks as expected:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Mar 29 2022, 6:41 PM
atul edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mar 30 2022, 3:17 AM
This revision was landed with ongoing or failed builds.Mar 30 2022, 9:30 AM
This revision was automatically updated to reflect the committed changes.