Diff 11038

.eslintignore

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
contentStringForMediaArray,		contentStringForMediaArray,
multimediaMessagePreview,		multimediaMessagePreview,
shimUploadURI,
} from '../../media/media-utils';		} from '../../media/media-utils';
import type { PlatformDetails } from '../../types/device-types';		import type { PlatformDetails } from '../../types/device-types';
import type { Media, Video, Image } from '../../types/media-types';
import {		import {
messageTypes,		messageTypes,
assertMessageType,		assertMessageType,
isMediaMessageType,		isMediaMessageType,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
MessageInfo,		MessageInfo,
RawMessageInfo,		RawMessageInfo,
RawMultimediaMessageInfo,
ClientDBMessageInfo,		ClientDBMessageInfo,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
ImagesMessageData,		ImagesMessageData,
RawImagesMessageInfo,		RawImagesMessageInfo,
ImagesMessageInfo,		ImagesMessageInfo,
} from '../../types/messages/images';		} from '../../types/messages/images';
import type {		import type {
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines	): RawMediaMessageInfo \| RawImagesMessageInfo {
}		}
},		},

shimUnsupportedMessageInfo(		shimUnsupportedMessageInfo(
rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,		rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,
platformDetails: ?PlatformDetails,		platformDetails: ?PlatformDetails,
): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {		): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {		if (rawMessageInfo.type === messageTypes.IMAGES) {
const shimmedRawMessageInfo = shimMediaMessageInfo(		return rawMessageInfo;
rawMessageInfo,
platformDetails,
);
return shimmedRawMessageInfo;
} else {		} else {
		ashoatUnsubmitted Not Done Inline Actions Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't necessary ashoat: Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't…
		rohanAuthorUnsubmitted Done Inline Actions Do you have a preference on merging the if statements or keeping the logic separate? if (rawMessageInfo.type === messageTypes.IMAGES) { return rawMessageInfo; } if (hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } vs. if (rawMessageInfo.type === messageTypes.IMAGES \|\| hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } rohan: Do you have a preference on merging the if statements or keeping the logic separate? ```…
		ashoatUnsubmitted Not Done Inline Actions No strong preference. I would probably keep the former personally but I'm okay either way ashoat: No strong preference. I would probably keep the former personally but I'm okay either way
const shimmedRawMessageInfo = shimMediaMessageInfo(
rawMessageInfo,
platformDetails,
);
// TODO figure out first native codeVersion supporting video playback		// TODO figure out first native codeVersion supporting video playback
		ashoatUnsubmitted Not Done Inline Actions I think we can remove this `TODO`, right @atul? ashoat: I think we can remove this `TODO`, right @atul?
		atulUnsubmitted Not Done Inline Actions Yes, sorry I should have remove that earlier. atul: Yes, sorry I should have remove that earlier.
if (hasMinCodeVersion(platformDetails, 158)) {		if (hasMinCodeVersion(platformDetails, 158)) {
return shimmedRawMessageInfo;		return rawMessageInfo;
}		}
const { id } = shimmedRawMessageInfo;		const { id } = rawMessageInfo;
invariant(id !== null && id !== undefined, 'id should be set on server');		invariant(id !== null && id !== undefined, 'id should be set on server');
return {		return {
type: messageTypes.UNSUPPORTED,		type: messageTypes.UNSUPPORTED,
id,		id,
threadID: shimmedRawMessageInfo.threadID,		threadID: rawMessageInfo.threadID,
creatorID: shimmedRawMessageInfo.creatorID,		creatorID: rawMessageInfo.creatorID,
time: shimmedRawMessageInfo.time,		time: rawMessageInfo.time,
robotext: multimediaMessagePreview(shimmedRawMessageInfo),		robotext: multimediaMessagePreview(rawMessageInfo),
unsupportedMessageInfo: shimmedRawMessageInfo,		unsupportedMessageInfo: rawMessageInfo,
};		};
}		}
},		},

unshimMessageInfo(		unshimMessageInfo(
unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,		unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,
messageInfo: RawMessageInfo,		messageInfo: RawMessageInfo,
): ?RawMessageInfo {		): ?RawMessageInfo {
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines	): string {
);		);
},		},

generatesNotifs: async () => pushTypes.NOTIF,		generatesNotifs: async () => pushTypes.NOTIF,

includedInRepliesCount: true,		includedInRepliesCount: true,
});		});

function shimMediaMessageInfo(
rawMessageInfo: RawMultimediaMessageInfo,
platformDetails: ?PlatformDetails,
): RawMultimediaMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {
let uriChanged = false;
const newMedia: Image[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawImagesMessageInfo);
} else {
let uriChanged = false;
const newMedia: Media[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else if (singleMedia.type === 'photo') {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Video));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawMediaMessageInfo);
}
}

// Four photos were uploaded before dimensions were calculated server-side,		// Four photos were uploaded before dimensions were calculated server-side,
// and delivered to clients without dimensions in the MultimediaMessageInfo.		// and delivered to clients without dimensions in the MultimediaMessageInfo.
const preDimensionUploads = {		const preDimensionUploads = {
'156642': { width: 1440, height: 1080 },		'156642': { width: 1440, height: 1080 },
'156649': { width: 720, height: 803 },		'156649': { width: 720, height: 803 },
'156794': { width: 720, height: 803 },		'156794': { width: 720, height: 803 },
'156877': { width: 574, height: 454 },		'156877': { width: 574, height: 454 },
};		};

View Options

.eslintrc.json

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
contentStringForMediaArray,		contentStringForMediaArray,
multimediaMessagePreview,		multimediaMessagePreview,
shimUploadURI,
} from '../../media/media-utils';		} from '../../media/media-utils';
import type { PlatformDetails } from '../../types/device-types';		import type { PlatformDetails } from '../../types/device-types';
import type { Media, Video, Image } from '../../types/media-types';
import {		import {
messageTypes,		messageTypes,
assertMessageType,		assertMessageType,
isMediaMessageType,		isMediaMessageType,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
MessageInfo,		MessageInfo,
RawMessageInfo,		RawMessageInfo,
RawMultimediaMessageInfo,
ClientDBMessageInfo,		ClientDBMessageInfo,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
ImagesMessageData,		ImagesMessageData,
RawImagesMessageInfo,		RawImagesMessageInfo,
ImagesMessageInfo,		ImagesMessageInfo,
} from '../../types/messages/images';		} from '../../types/messages/images';
import type {		import type {
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines	): RawMediaMessageInfo \| RawImagesMessageInfo {
}		}
},		},

shimUnsupportedMessageInfo(		shimUnsupportedMessageInfo(
rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,		rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,
platformDetails: ?PlatformDetails,		platformDetails: ?PlatformDetails,
): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {		): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {		if (rawMessageInfo.type === messageTypes.IMAGES) {
const shimmedRawMessageInfo = shimMediaMessageInfo(		return rawMessageInfo;
rawMessageInfo,
platformDetails,
);
return shimmedRawMessageInfo;
} else {		} else {
		ashoatUnsubmitted Not Done Inline Actions Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't necessary ashoat: Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't…
		rohanAuthorUnsubmitted Done Inline Actions Do you have a preference on merging the if statements or keeping the logic separate? if (rawMessageInfo.type === messageTypes.IMAGES) { return rawMessageInfo; } if (hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } vs. if (rawMessageInfo.type === messageTypes.IMAGES \|\| hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } rohan: Do you have a preference on merging the if statements or keeping the logic separate? ```…
		ashoatUnsubmitted Not Done Inline Actions No strong preference. I would probably keep the former personally but I'm okay either way ashoat: No strong preference. I would probably keep the former personally but I'm okay either way
const shimmedRawMessageInfo = shimMediaMessageInfo(
rawMessageInfo,
platformDetails,
);
// TODO figure out first native codeVersion supporting video playback		// TODO figure out first native codeVersion supporting video playback
		ashoatUnsubmitted Not Done Inline Actions I think we can remove this `TODO`, right @atul? ashoat: I think we can remove this `TODO`, right @atul?
		atulUnsubmitted Not Done Inline Actions Yes, sorry I should have remove that earlier. atul: Yes, sorry I should have remove that earlier.
if (hasMinCodeVersion(platformDetails, 158)) {		if (hasMinCodeVersion(platformDetails, 158)) {
return shimmedRawMessageInfo;		return rawMessageInfo;
}		}
const { id } = shimmedRawMessageInfo;		const { id } = rawMessageInfo;
invariant(id !== null && id !== undefined, 'id should be set on server');		invariant(id !== null && id !== undefined, 'id should be set on server');
return {		return {
type: messageTypes.UNSUPPORTED,		type: messageTypes.UNSUPPORTED,
id,		id,
threadID: shimmedRawMessageInfo.threadID,		threadID: rawMessageInfo.threadID,
creatorID: shimmedRawMessageInfo.creatorID,		creatorID: rawMessageInfo.creatorID,
time: shimmedRawMessageInfo.time,		time: rawMessageInfo.time,
robotext: multimediaMessagePreview(shimmedRawMessageInfo),		robotext: multimediaMessagePreview(rawMessageInfo),
unsupportedMessageInfo: shimmedRawMessageInfo,		unsupportedMessageInfo: rawMessageInfo,
};		};
}		}
},		},

unshimMessageInfo(		unshimMessageInfo(
unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,		unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,
messageInfo: RawMessageInfo,		messageInfo: RawMessageInfo,
): ?RawMessageInfo {		): ?RawMessageInfo {
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines	): string {
);		);
},		},

generatesNotifs: async () => pushTypes.NOTIF,		generatesNotifs: async () => pushTypes.NOTIF,

includedInRepliesCount: true,		includedInRepliesCount: true,
});		});

function shimMediaMessageInfo(
rawMessageInfo: RawMultimediaMessageInfo,
platformDetails: ?PlatformDetails,
): RawMultimediaMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {
let uriChanged = false;
const newMedia: Image[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawImagesMessageInfo);
} else {
let uriChanged = false;
const newMedia: Media[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else if (singleMedia.type === 'photo') {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Video));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawMediaMessageInfo);
}
}

// Four photos were uploaded before dimensions were calculated server-side,		// Four photos were uploaded before dimensions were calculated server-side,
// and delivered to clients without dimensions in the MultimediaMessageInfo.		// and delivered to clients without dimensions in the MultimediaMessageInfo.
const preDimensionUploads = {		const preDimensionUploads = {
'156642': { width: 1440, height: 1080 },		'156642': { width: 1440, height: 1080 },
'156649': { width: 720, height: 803 },		'156649': { width: 720, height: 803 },
'156794': { width: 720, height: 803 },		'156794': { width: 720, height: 803 },
'156877': { width: 574, height: 454 },		'156877': { width: 574, height: 454 },
};		};

View Options

.github/workflows/android_ci.yml

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
contentStringForMediaArray,		contentStringForMediaArray,
multimediaMessagePreview,		multimediaMessagePreview,
shimUploadURI,
} from '../../media/media-utils';		} from '../../media/media-utils';
import type { PlatformDetails } from '../../types/device-types';		import type { PlatformDetails } from '../../types/device-types';
import type { Media, Video, Image } from '../../types/media-types';
import {		import {
messageTypes,		messageTypes,
assertMessageType,		assertMessageType,
isMediaMessageType,		isMediaMessageType,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
MessageInfo,		MessageInfo,
RawMessageInfo,		RawMessageInfo,
RawMultimediaMessageInfo,
ClientDBMessageInfo,		ClientDBMessageInfo,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
ImagesMessageData,		ImagesMessageData,
RawImagesMessageInfo,		RawImagesMessageInfo,
ImagesMessageInfo,		ImagesMessageInfo,
} from '../../types/messages/images';		} from '../../types/messages/images';
import type {		import type {
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines	): RawMediaMessageInfo \| RawImagesMessageInfo {
}		}
},		},

shimUnsupportedMessageInfo(		shimUnsupportedMessageInfo(
rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,		rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,
platformDetails: ?PlatformDetails,		platformDetails: ?PlatformDetails,
): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {		): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {		if (rawMessageInfo.type === messageTypes.IMAGES) {
const shimmedRawMessageInfo = shimMediaMessageInfo(		return rawMessageInfo;
rawMessageInfo,
platformDetails,
);
return shimmedRawMessageInfo;
} else {		} else {
		ashoatUnsubmitted Not Done Inline Actions Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't necessary ashoat: Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't…
		rohanAuthorUnsubmitted Done Inline Actions Do you have a preference on merging the if statements or keeping the logic separate? if (rawMessageInfo.type === messageTypes.IMAGES) { return rawMessageInfo; } if (hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } vs. if (rawMessageInfo.type === messageTypes.IMAGES \|\| hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } rohan: Do you have a preference on merging the if statements or keeping the logic separate? ```…
		ashoatUnsubmitted Not Done Inline Actions No strong preference. I would probably keep the former personally but I'm okay either way ashoat: No strong preference. I would probably keep the former personally but I'm okay either way
const shimmedRawMessageInfo = shimMediaMessageInfo(
rawMessageInfo,
platformDetails,
);
// TODO figure out first native codeVersion supporting video playback		// TODO figure out first native codeVersion supporting video playback
		ashoatUnsubmitted Not Done Inline Actions I think we can remove this `TODO`, right @atul? ashoat: I think we can remove this `TODO`, right @atul?
		atulUnsubmitted Not Done Inline Actions Yes, sorry I should have remove that earlier. atul: Yes, sorry I should have remove that earlier.
if (hasMinCodeVersion(platformDetails, 158)) {		if (hasMinCodeVersion(platformDetails, 158)) {
return shimmedRawMessageInfo;		return rawMessageInfo;
}		}
const { id } = shimmedRawMessageInfo;		const { id } = rawMessageInfo;
invariant(id !== null && id !== undefined, 'id should be set on server');		invariant(id !== null && id !== undefined, 'id should be set on server');
return {		return {
type: messageTypes.UNSUPPORTED,		type: messageTypes.UNSUPPORTED,
id,		id,
threadID: shimmedRawMessageInfo.threadID,		threadID: rawMessageInfo.threadID,
creatorID: shimmedRawMessageInfo.creatorID,		creatorID: rawMessageInfo.creatorID,
time: shimmedRawMessageInfo.time,		time: rawMessageInfo.time,
robotext: multimediaMessagePreview(shimmedRawMessageInfo),		robotext: multimediaMessagePreview(rawMessageInfo),
unsupportedMessageInfo: shimmedRawMessageInfo,		unsupportedMessageInfo: rawMessageInfo,
};		};
}		}
},		},

unshimMessageInfo(		unshimMessageInfo(
unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,		unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,
messageInfo: RawMessageInfo,		messageInfo: RawMessageInfo,
): ?RawMessageInfo {		): ?RawMessageInfo {
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines	): string {
);		);
},		},

generatesNotifs: async () => pushTypes.NOTIF,		generatesNotifs: async () => pushTypes.NOTIF,

includedInRepliesCount: true,		includedInRepliesCount: true,
});		});

function shimMediaMessageInfo(
rawMessageInfo: RawMultimediaMessageInfo,
platformDetails: ?PlatformDetails,
): RawMultimediaMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {
let uriChanged = false;
const newMedia: Image[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawImagesMessageInfo);
} else {
let uriChanged = false;
const newMedia: Media[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else if (singleMedia.type === 'photo') {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Video));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawMediaMessageInfo);
}
}

// Four photos were uploaded before dimensions were calculated server-side,		// Four photos were uploaded before dimensions were calculated server-side,
// and delivered to clients without dimensions in the MultimediaMessageInfo.		// and delivered to clients without dimensions in the MultimediaMessageInfo.
const preDimensionUploads = {		const preDimensionUploads = {
'156642': { width: 1440, height: 1080 },		'156642': { width: 1440, height: 1080 },
'156649': { width: 720, height: 803 },		'156649': { width: 720, height: 803 },
'156794': { width: 720, height: 803 },		'156794': { width: 720, height: 803 },
'156877': { width: 574, height: 454 },		'156877': { width: 574, height: 454 },
};		};

View Options

.github/workflows/eslint_flow_jest.yml

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
contentStringForMediaArray,		contentStringForMediaArray,
multimediaMessagePreview,		multimediaMessagePreview,
shimUploadURI,
} from '../../media/media-utils';		} from '../../media/media-utils';
import type { PlatformDetails } from '../../types/device-types';		import type { PlatformDetails } from '../../types/device-types';
import type { Media, Video, Image } from '../../types/media-types';
import {		import {
messageTypes,		messageTypes,
assertMessageType,		assertMessageType,
isMediaMessageType,		isMediaMessageType,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
MessageInfo,		MessageInfo,
RawMessageInfo,		RawMessageInfo,
RawMultimediaMessageInfo,
ClientDBMessageInfo,		ClientDBMessageInfo,
} from '../../types/message-types';		} from '../../types/message-types';
import type {		import type {
ImagesMessageData,		ImagesMessageData,
RawImagesMessageInfo,		RawImagesMessageInfo,
ImagesMessageInfo,		ImagesMessageInfo,
} from '../../types/messages/images';		} from '../../types/messages/images';
import type {		import type {
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines	): RawMediaMessageInfo \| RawImagesMessageInfo {
}		}
},		},

shimUnsupportedMessageInfo(		shimUnsupportedMessageInfo(
rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,		rawMessageInfo: RawMediaMessageInfo \| RawImagesMessageInfo,
platformDetails: ?PlatformDetails,		platformDetails: ?PlatformDetails,
): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {		): RawMediaMessageInfo \| RawImagesMessageInfo \| RawUnsupportedMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {		if (rawMessageInfo.type === messageTypes.IMAGES) {
const shimmedRawMessageInfo = shimMediaMessageInfo(		return rawMessageInfo;
rawMessageInfo,
platformDetails,
);
return shimmedRawMessageInfo;
} else {		} else {
		ashoatUnsubmitted Not Done Inline Actions Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't necessary ashoat: Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't…
		rohanAuthorUnsubmitted Done Inline Actions Do you have a preference on merging the if statements or keeping the logic separate? if (rawMessageInfo.type === messageTypes.IMAGES) { return rawMessageInfo; } if (hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } vs. if (rawMessageInfo.type === messageTypes.IMAGES \|\| hasMinCodeVersion(platformDetails, 158)) { return rawMessageInfo; } rohan: Do you have a preference on merging the if statements or keeping the logic separate? ```…
		ashoatUnsubmitted Not Done Inline Actions No strong preference. I would probably keep the former personally but I'm okay either way ashoat: No strong preference. I would probably keep the former personally but I'm okay either way
const shimmedRawMessageInfo = shimMediaMessageInfo(
rawMessageInfo,
platformDetails,
);
// TODO figure out first native codeVersion supporting video playback		// TODO figure out first native codeVersion supporting video playback
		ashoatUnsubmitted Not Done Inline Actions I think we can remove this `TODO`, right @atul? ashoat: I think we can remove this `TODO`, right @atul?
		atulUnsubmitted Not Done Inline Actions Yes, sorry I should have remove that earlier. atul: Yes, sorry I should have remove that earlier.
if (hasMinCodeVersion(platformDetails, 158)) {		if (hasMinCodeVersion(platformDetails, 158)) {
return shimmedRawMessageInfo;		return rawMessageInfo;
}		}
const { id } = shimmedRawMessageInfo;		const { id } = rawMessageInfo;
invariant(id !== null && id !== undefined, 'id should be set on server');		invariant(id !== null && id !== undefined, 'id should be set on server');
return {		return {
type: messageTypes.UNSUPPORTED,		type: messageTypes.UNSUPPORTED,
id,		id,
threadID: shimmedRawMessageInfo.threadID,		threadID: rawMessageInfo.threadID,
creatorID: shimmedRawMessageInfo.creatorID,		creatorID: rawMessageInfo.creatorID,
time: shimmedRawMessageInfo.time,		time: rawMessageInfo.time,
robotext: multimediaMessagePreview(shimmedRawMessageInfo),		robotext: multimediaMessagePreview(rawMessageInfo),
unsupportedMessageInfo: shimmedRawMessageInfo,		unsupportedMessageInfo: rawMessageInfo,
};		};
}		}
},		},

unshimMessageInfo(		unshimMessageInfo(
unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,		unwrapped: RawMediaMessageInfo \| RawImagesMessageInfo,
messageInfo: RawMessageInfo,		messageInfo: RawMessageInfo,
): ?RawMessageInfo {		): ?RawMessageInfo {
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines	): string {
);		);
},		},

generatesNotifs: async () => pushTypes.NOTIF,		generatesNotifs: async () => pushTypes.NOTIF,

includedInRepliesCount: true,		includedInRepliesCount: true,
});		});

function shimMediaMessageInfo(
rawMessageInfo: RawMultimediaMessageInfo,
platformDetails: ?PlatformDetails,
): RawMultimediaMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {
let uriChanged = false;
const newMedia: Image[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawImagesMessageInfo);
} else {
let uriChanged = false;
const newMedia: Media[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else if (singleMedia.type === 'photo') {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Video));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawMediaMessageInfo);
}
}

// Four photos were uploaded before dimensions were calculated server-side,		// Four photos were uploaded before dimensions were calculated server-side,
// and delivered to clients without dimensions in the MultimediaMessageInfo.		// and delivered to clients without dimensions in the MultimediaMessageInfo.
const preDimensionUploads = {		const preDimensionUploads = {
'156642': { width: 1440, height: 1080 },		'156642': { width: 1440, height: 1080 },
'156649': { width: 720, height: 803 },		'156649': { width: 720, height: 803 },
'156794': { width: 720, height: 803 },		'156794': { width: 720, height: 803 },
'156877': { width: 574, height: 454 },		'156877': { width: 574, height: 454 },
};		};