Page MenuHomePhabricator
Differential D3661

[services][identity] Add .dockerignore file for Identity Service
ClosedPublic
Actions

Authored by varun on Apr 7 2022, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 6:23 AM
Unknown Object (File)
Wed, Nov 27, 4:34 AM
Unknown Object (File)
Tue, Nov 26, 5:38 AM
Unknown Object (File)
Wed, Nov 13, 12:48 PM
Unknown Object (File)
Wed, Nov 13, 12:47 PM
Unknown Object (File)
Sat, Nov 9, 12:47 AM
Unknown Object (File)
Tue, Nov 5, 7:30 PM
Unknown Object (File)
Sun, Nov 3, 1:24 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• jim
• karol
ashoat
Commits
rCOMMb3ee072a1cf3: [services][identity] Add .dockerignore file for Identity Service
Summary

We don't need to copy some of the files from the identity directory

Depends on D3593

Test Plan

built, ran docker container

Diff Detail

Repository
rCOMM Comm
Branch
varun/identity_service (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Apr 7 2022, 3:18 PM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 7 2022, 3:18 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2022, 3:20 PM
Harbormaster failed remote builds in B7998: Diff 11203!
varun requested review of this revision.Apr 8 2022, 7:24 AM
varun added a reviewer: • karol.Apr 8 2022, 8:06 AM
ashoat requested changes to this revision.Apr 10 2022, 7:12 PM

Please delete services/identity/target from the root .gitignore

This revision now requires changes to proceed.Apr 10 2022, 7:12 PM
varun requested review of this revision.Apr 11 2022, 7:49 AM
In D3661#101092, @ashoat wrote:

Please delete services/identity/target from the root .gitignore

This is a .dockerignore file not .gitignore. This is just to avoid copying over unnecessary files to our Docker container.

ashoat accepted this revision.Apr 11 2022, 8:25 AM

Oh oops

This revision is now accepted and ready to land.Apr 11 2022, 8:25 AM
varun edited parent revisions, added: D3590: [services][identity] add identity service port to the .env file for docker-compose; removed: D3593: [services][identity] Dockerfile for the identity service.Apr 11 2022, 12:22 PM
varun added a child revision: D3593: [services][identity] Dockerfile for the identity service.
varun removed a parent revision: D3590: [services][identity] add identity service port to the .env file for docker-compose.Apr 11 2022, 1:10 PM
This revision was landed with ongoing or failed builds.Apr 11 2022, 1:13 PM
Closed by commit rCOMMb3ee072a1cf3: [services][identity] Add .dockerignore file for Identity Service (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMb3ee072a1cf3: [services][identity] Add .dockerignore file for Identity Service.
ashoat added inline comments.Apr 11 2022, 4:42 PM
services/identity/.dockerignore
4 ↗(On Diff #11319)

I don't think this folder should exist outside of the root dir, right?

5 ↗(On Diff #11319)

Does a later diff introduce this?

Revision Contents
Changeset List

PathSize
services/
identity/
5 lines

Diff 11203

View Options

services/identity/.dockerignore

Loading...