[web] Create `ColorSelectorButton`s in `ColorSelector` iteratively to reduce repetition
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 1:44 PM.

Details

Reviewers

tomek
• jacek

Commits

Summary

Instead of copy/pasting this 10 times, we can easily create ColorSelectorButtons iteratively thanks to the flex-wrap layout.

Depends on D3703

Test Plan

Things continue to look/behave as expected:

Repository

rCOMM Comm

Branch

landapril12 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

atul edited the test plan for this revision. (Show Details)Apr 11 2022, 1:46 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 11 2022, 1:51 PM

atul requested review of this revision.Apr 11 2022, 1:56 PM

Do we have a plan for threads that have legacy colors (arbitrary)?

This revision is now accepted and ready to land.Apr 12 2022, 3:39 AM

Do we have a plan for threads that have legacy colors (arbitrary)?

Yeah the plan is:

Redesign the existing color picker component in native
Write a DB migration that "snaps" thread colors to the closest "selectedThreadColor" (probably using tinycolor)
Modify code on the server to similarly "snap" thread colors to closest "selectedThreadColor" to handle users who may be on old clients (with the old color picker)