[web] [fix] ENG-895 Chat Thread List Menu button and time doesn't match design
ClosedPublic
Actions

Authored by • benschac on Mar 17 2022, 1:35 PM.

Details

Reviewers

atul
tomek
• jacek
ashoat

Commits

rCOMMe2fd3fbb497f: [web] [fix] ENG-895 Chat Thread List Menu button and time doesn't match design

Summary

https://linear.app/comm/issue/ENG-895/chat-thread-list-menu-button-and-time-doesnt-match-design

Space out menu button and last time. The size of the chat thread list item is still the incorrect size and will be updated in another diff.

before:

Image 2022-03-17 at 4.36.31 PM.jpg (736×866 px, 81 KB)

after:

Image 2022-03-17 at 4.36.14 PM.jpg (632×918 px, 47 KB)

Test Plan

Chat thread list items should look like the screen shot and closer to figma. Will look much closer to figma once the chat thread list items are correctly sized.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 17 2022, 1:35 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 17 2022, 1:35 PM

• benschac edited the summary of this revision. (Show Details)Mar 17 2022, 1:37 PM

• benschac edited the test plan for this revision. (Show Details)

• benschac added reviewers: tomek, • jacek.

• benschac added a parent revision: D3444: [web] [fix] ENG-730 add notif dot for thread.

Harbormaster completed remote builds in B7455: Diff 10502.Mar 17 2022, 1:40 PM

• benschac requested review of this revision.Mar 17 2022, 1:40 PM

• benschac added a child revision: D3455: [web] [fix] benjamin/eng-896-color-splotch-wrong-size-currently-40px.Mar 17 2022, 2:51 PM

tomek accepted this revision.Mar 18 2022, 4:36 AM

tomek added inline comments.

web/chat/chat-thread-list.css
43 ↗	(On Diff #10502)	What do you think about adding a class to that div instead? Having a sibling selector might be confusing as changing order of divs will change their appearance. If the div had a class, it would be more readable.

This revision is now accepted and ready to land.Mar 18 2022, 4:36 AM

Please name your diffs something human-readable

This revision now requires changes to proceed.Mar 20 2022, 8:55 PM

• benschac retitled this revision from [web] [fix] benjamin/eng-895-chat-thread-list-menu-button-and-time to [web] [fix] ENG-895 Chat Thread List Menu button and time doesn't match design.Mar 21 2022, 8:34 AM

ashoat accepted this revision.Mar 21 2022, 8:40 AM

This revision is now accepted and ready to land.Mar 21 2022, 8:40 AM

• benschac added a child revision: D3480: [web] [fix] thread list size and paddings are incorrect.Mar 21 2022, 12:37 PM

• benschac added inline comments.Mar 23 2022, 6:33 AM