Page MenuHomePhabricator
Differential D3725

[web] [fix] fix unread last message timestamp
ClosedPublic
Actions

Authored by • benschac on Apr 13 2022, 10:46 AM.
Tags
None
Referenced Files
F3378639: D3725.id11625.diff
Wed, Nov 27, 12:04 PM
Unknown Object (File)
Sat, Nov 9, 5:54 PM
Unknown Object (File)
Sat, Nov 9, 9:09 AM
Unknown Object (File)
Sat, Nov 9, 9:00 AM
Unknown Object (File)
Sat, Nov 9, 7:12 AM
Unknown Object (File)
Fri, Nov 8, 2:23 PM
Unknown Object (File)
Fri, Nov 8, 11:10 AM
Unknown Object (File)
Oct 28 2024, 3:01 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
• jacek
tomek
Commits
rCOMMbcf164d0220b: [web] [fix] fix unread last message timestamp
Summary

size and padding didn't match figma.

after:

Image 2022-04-13 at 1.42.25 PM.jpg (180×818 px, 12 KB)

before:

Image 2022-04-13 at 1.40.32 PM.jpg (206×854 px, 12 KB)

Test Plan

it should match figma

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79583

Diff Detail

Repository
rCOMM Comm
Branch
new-fix-side-bar
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Apr 13 2022, 10:46 AM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 13 2022, 10:46 AM
• benschac edited the summary of this revision. (Show Details)Apr 13 2022, 10:47 AM
• benschac edited the test plan for this revision. (Show Details)
• benschac edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 13 2022, 10:51 AM
Harbormaster failed remote builds in B8172: Diff 11438!
• benschac requested review of this revision.Apr 13 2022, 10:56 AM
• benschac added reviewers: • jacek, tomek.
• benschac added a parent revision: D3539: [web] [feat] [ENG-766] toggle longer arrow for multiple thread sidebars in chat thread list.
tomek accepted this revision.Apr 14 2022, 1:55 AM
This revision is now accepted and ready to land.Apr 14 2022, 1:55 AM
This revision was landed with ongoing or failed builds.Apr 19 2022, 10:09 AM
Closed by commit rCOMMbcf164d0220b: [web] [fix] fix unread last message timestamp (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMbcf164d0220b: [web] [fix] fix unread last message timestamp.

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines

Diff 11438

View Options

web/chat/chat-thread-list.css

Loading...