Differential D3751

[landing] [chore] [ENG-1010] fix import order in webpack
ClosedPublic
Actions

Authored by • benschac on Apr 15 2022, 1:46 PM.

Tags

None

Referenced Files

	F3356091: D3751.id11560.diff
	Sat, Nov 23, 4:50 PM

	F3355581: D3751.diff
	Sat, Nov 23, 2:41 PM

	Unknown Object (File)
	Fri, Nov 15, 6:09 AM

	Unknown Object (File)
	Wed, Nov 13, 12:49 PM

	Unknown Object (File)
	Sun, Nov 10, 12:39 AM

	Unknown Object (File)
	Fri, Nov 8, 8:21 PM

	Unknown Object (File)
	Fri, Nov 8, 8:21 PM

	Unknown Object (File)
	Fri, Nov 8, 8:21 PM

Subscribers

Details

Reviewers

atul
tomek
• abosh
• jacek

Commits

rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack

Summary

there was an import order warning. fixed it.
https://linear.app/comm/issue/ENG-1010/webpack-linting-chore

Test Plan

n/a

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 15 2022, 1:46 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 15 2022, 1:46 PM

• benschac added a parent revision: D3750: [landing] [chore] [ENG-1010] add disable comments in webpack config.Apr 15 2022, 1:46 PM

Harbormaster completed remote builds in B8241: Diff 11526.Apr 15 2022, 1:55 PM

• benschac requested review of this revision.Apr 15 2022, 1:55 PM

• benschac retitled this revision from [landing] [chore] fix import order in webpack to [landing] [chore] [ENG-1010] fix import order in webpack.Apr 15 2022, 1:58 PM

• benschac edited the summary of this revision. (Show Details)Apr 18 2022, 7:22 AM

• benschac added reviewers: tomek, • abosh, • jacek.

Looks good

(probably could have been combined with D3753)

atul accepted this revision.Apr 18 2022, 11:04 AM

This revision is now accepted and ready to land.Apr 18 2022, 11:04 AM

rebase

Harbormaster completed remote builds in B8269: Diff 11560.Apr 18 2022, 12:07 PM

Closed by commit rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack (authored by • benschac). · Explain WhyApr 18 2022, 12:18 PM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack.

Revision Contents
Changeset List

Path

Size

landing/

webpack.config.cjs

5 lines

Diff 11526

landing/webpack.config.cjs

Loading...