dot wasn't aligned with color splotch
before:
after:
Details
Details
- Reviewers
atul • jacek • abosh tomek - Commits
- rCOMM0aa0ced7a43d: [web] [fix] dot alignment
send a new message, un read dot should be aligned
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D3723
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
The summary is confusing. Please add some description to the images, telling which one is "before" and which is "after".
| web/chat/chat-thread-list.css | ||
|---|---|---|
| 105–114 ↗ | (On Diff #11429) | Why do we need to specify the exact height in two places? Can we make one of them being computed based on the other (e.g. flex: 1)? |
| web/chat/chat-thread-list.css | ||
|---|---|---|
| 105–114 ↗ | (On Diff #11429) | makes sense, I don't think we need it either. |
Comment Actions
Accepting, but it would be great if you could address this
The summary is confusing. Please add some description to the images, telling which one is "before" and which is "after".
It looks like both images are from "after" - am I right? Could you also check if it looks ok when we have a thread with two sidebars, from which only one has a dot?
It's important to make the diffs less confusing - for future reference.
Comment Actions
@benschac, not sure how many more times I'll need to repeat this :( I hope zero, but hard to believe at this point.
Please. Do. Not. Land. Diffs. Until. You. Address. All. Comments.
Comment Actions
I can, sorry about this. I'm usually pretty consistent on labeling screenshots. But, this time I missed it.
It looks like both images are from "after" - am I right? Could you also check if it looks ok when we have a thread with two sidebars, from which only one has a dot?
It's important to make the diffs less confusing - for future reference.
- You're right. The before image is incorrect.
two threads, one dot:
(additionally)
two threads, two dots
(additionally)
two threads, two dot sidebars + chat thread list item
