Page MenuHomePhabricator
Differential D3751

[landing] [chore] [ENG-1010] fix import order in webpack
ClosedPublic
Actions

Authored by • benschac on Apr 15 2022, 1:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 1:46 AM
Unknown Object (File)
Thu, Mar 20, 2:58 PM
Unknown Object (File)
Wed, Mar 12, 10:42 PM
Unknown Object (File)
Mar 1 2025, 7:41 PM
Unknown Object (File)
Feb 27 2025, 3:49 PM
Unknown Object (File)
Feb 20 2025, 9:17 PM
Unknown Object (File)
Feb 5 2025, 11:37 PM
Unknown Object (File)
Feb 4 2025, 6:31 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
tomek
• abosh
• jacek
Commits
rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack
Summary

there was an import order warning. fixed it.
https://linear.app/comm/issue/ENG-1010/webpack-linting-chore

Test Plan

n/a

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Apr 15 2022, 1:46 PM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 15 2022, 1:46 PM
• benschac added a parent revision: D3750: [landing] [chore] [ENG-1010] add disable comments in webpack config.Apr 15 2022, 1:46 PM
Harbormaster completed remote builds in B8241: Diff 11526.Apr 15 2022, 1:55 PM
• benschac requested review of this revision.Apr 15 2022, 1:55 PM
• benschac retitled this revision from [landing] [chore] fix import order in webpack to [landing] [chore] [ENG-1010] fix import order in webpack.Apr 15 2022, 1:58 PM
• benschac edited the summary of this revision. (Show Details)Apr 18 2022, 7:22 AM
• benschac added reviewers: tomek, • abosh, • jacek.
atul added a comment.Apr 18 2022, 11:00 AM

Looks good

(probably could have been combined with D3753)

atul accepted this revision.Apr 18 2022, 11:04 AM
This revision is now accepted and ready to land.Apr 18 2022, 11:04 AM
• benschac updated this revision to Diff 11560.Apr 18 2022, 12:00 PM

rebase

Harbormaster completed remote builds in B8269: Diff 11560.Apr 18 2022, 12:07 PM
Closed by commit rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack (authored by • benschac). · Explain WhyApr 18 2022, 12:18 PM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack.

Revision Contents
Changeset List

PathSize
landing/
5 lines

Diff 11560

View Options

landing/webpack.config.cjs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
leaveThreadActionTypes, leaveThreadActionTypes,
useLeaveThread, useLeaveThread,
} from 'lib/actions/thread-actions.js'; } from 'lib/actions/thread-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/swmansion-icon.react.js'; import SWMansionIcon from 'lib/components/swmansion-icon.react.js';
import { usePromoteSidebar } from 'lib/hooks/promote-sidebar.react.js'; import { usePromoteSidebar } from 'lib/hooks/promote-sidebar.react.js';
import { childThreadInfos } from 'lib/selectors/thread-selectors.js'; import { childThreadInfos } from 'lib/selectors/thread-selectors.js';
import { import {
threadHasPermission,
threadIsChannel, threadIsChannel,
useThreadHasPermission,
viewerIsMember, viewerIsMember,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypes } from 'lib/types/thread-types-enum.js'; import { threadTypes } from 'lib/types/thread-types-enum.js';
import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js'; import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 106 Lines • ▼ Show 20 Lines return (
key="sidebars" key="sidebars"
text="Threads" text="Threads"
icon="arrow-right" icon="arrow-right"
onClick={onClickSidebars} onClick={onClickSidebars}
/> />
); );
}, [hasSidebars, onClickSidebars]); }, [hasSidebars, onClickSidebars]);
const canCreateSubchannels = React.useMemo( const canCreateSubchannels = useThreadHasPermission(
() => threadHasPermission(threadInfo, threadPermissions.CREATE_SUBCHANNELS), threadInfo,
[threadInfo], threadPermissions.CREATE_SUBCHANNELS,
); );
const hasSubchannels = React.useMemo(() => { const hasSubchannels = React.useMemo(() => {
return !!childThreads?.some(threadIsChannel); return !!childThreads?.some(threadIsChannel);
}, [childThreads]); }, [childThreads]);
const onClickViewSubchannels = React.useCallback( const onClickViewSubchannels = React.useCallback(
() => () =>
▲ Show 20 Lines • Show All 60 Lines • ▼ Show 20 Lines () =>
threadInfo={threadInfo} threadInfo={threadInfo}
onClose={popModal} onClose={popModal}
onConfirm={onConfirmLeaveThread} onConfirm={onConfirmLeaveThread}
/>, />,
), ),
[popModal, onConfirmLeaveThread, pushModal, threadInfo], [popModal, onConfirmLeaveThread, pushModal, threadInfo],
); );
const leaveThreadItem = React.useMemo(() => { const canLeaveThread = useThreadHasPermission(
const canLeaveThread = threadHasPermission(
threadInfo, threadInfo,
threadPermissions.LEAVE_THREAD, threadPermissions.LEAVE_THREAD,
); );
const leaveThreadItem = React.useMemo(() => {
if (!viewerIsMember(threadInfo) || !canLeaveThread) { if (!viewerIsMember(threadInfo) || !canLeaveThread) {
return null; return null;
} }
return ( return (
<MenuItem <MenuItem
key="leave" key="leave"
text="Leave chat" text="Leave chat"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo, canLeaveThread]);
const onClickPromoteSidebarToThread = React.useCallback( const onClickPromoteSidebarToThread = React.useCallback(
() => () =>
pushModal( pushModal(
<SidebarPromoteModal <SidebarPromoteModal
threadInfo={threadInfo} threadInfo={threadInfo}
onClose={popModal} onClose={popModal}
onConfirm={onPromoteSidebar} onConfirm={onPromoteSidebar}
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines