Page MenuHomePhabricator
Differential D3689

[services] Tunnelbroker - Database MessageItem tests
ClosedPublic
Actions

Authored by • max on Apr 11 2022, 3:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 1:09 PM
Unknown Object (File)
Mon, Nov 4, 1:09 PM
Unknown Object (File)
Sun, Nov 3, 4:01 PM
Unknown Object (File)
Sat, Nov 2, 9:59 AM
Unknown Object (File)
Sat, Nov 2, 9:59 AM
Unknown Object (File)
Sat, Nov 2, 9:59 AM
Unknown Object (File)
Sat, Nov 2, 7:48 AM
Unknown Object (File)
Sat, Nov 2, 7:48 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
varun
Commits
rCOMM399f89b37e22: [services] Tunnelbroker - Database MessageItem tests
Summary

Database (DynamoDB) item tests. For the MessageItem database entity we perform:

  • Check if the table is available,
  • Create and fulfill database item entity,
  • Put into the database table,
  • Find the record using the primary key,
  • Compare record fields of created item and item from database record,
  • Remove the testing record from the database.

Related linear task: ENG-686

Test Plan

Run yarn test-tunnelbroker-service all tests are run and succeed.

Diff Detail

Repository
rCOMM Comm
Branch
tunnelbroker-tests-database-messageitem
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Apr 11 2022, 3:50 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 11 2022, 3:50 AM
• max added reviewers: • karol, tomek, varun.Apr 11 2022, 3:50 AM
• max added a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.
• max mentioned this in D3643: [services] Tunnelbroker - Database item tests initialization.Apr 11 2022, 3:55 AM
Harbormaster completed remote builds in B8057: Diff 11276.Apr 11 2022, 3:55 AM
• max requested review of this revision.Apr 11 2022, 3:55 AM
tomek requested changes to this revision.Apr 11 2022, 5:55 AM

We also need to clarify our approach to randomness in D3654

services/tunnelbroker/test/DatabaseManagerTest.cpp
43–48 ↗(On Diff #11276)
This revision now requires changes to proceed.Apr 11 2022, 5:55 AM
• max updated this revision to Diff 11285.Apr 11 2022, 6:25 AM

Switch from memcmp to a simple EQ.

• max planned changes to this revision.Apr 11 2022, 6:25 AM
• max marked an inline comment as done.

Switching to the Plan changes until we clarify the random/non-random value for tests.

Harbormaster completed remote builds in B8066: Diff 11285.Apr 11 2022, 6:31 AM
• max updated this revision to Diff 11544.Apr 18 2022, 6:17 AM

Added tests with static variables along with generated ones following D3654#102087.

Harbormaster completed remote builds in B8253: Diff 11544.Apr 18 2022, 6:22 AM
• max updated this revision to Diff 11581.Apr 18 2022, 11:46 PM

Verbose output for generated values was added.

Harbormaster completed remote builds in B8285: Diff 11581.Apr 18 2022, 11:53 PM
• max updated this revision to Diff 11586.Apr 19 2022, 12:49 AM

Remove == equality to EQ only.

Harbormaster completed remote builds in B8290: Diff 11586.Apr 19 2022, 12:57 AM
• max added 1 blocking reviewer(s): tomek.Apr 19 2022, 2:06 AM
tomek requested changes to this revision.Apr 19 2022, 2:35 AM
tomek added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
26

We're testing db manager by putting a message item and checking if find returns a similar item - please update the test name

This revision now requires changes to proceed.Apr 19 2022, 2:35 AM
• max planned changes to this revision.Apr 20 2022, 12:40 PM
• max updated this revision to Diff 11701.Apr 21 2022, 1:23 AM

Changed the test names to reflect the actions inside.

• max marked an inline comment as done.Apr 21 2022, 1:28 AM
• max added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
26

We're testing db manager by putting a message item and checking if find returns a similar item - please update the test name

Agree, names were changed.

Harbormaster completed remote builds in B8389: Diff 11701.Apr 21 2022, 1:28 AM
tomek accepted this revision.Apr 21 2022, 2:37 AM
This revision is now accepted and ready to land.Apr 21 2022, 2:37 AM
• max updated this revision to Diff 11720.Apr 21 2022, 4:46 AM
• max marked an inline comment as done.

Rebase on master.

Harbormaster completed remote builds in B8401: Diff 11720.Apr 21 2022, 4:51 AM
Closed by commit rCOMM399f89b37e22: [services] Tunnelbroker - Database MessageItem tests (authored by • max). · Explain WhyApr 21 2022, 4:53 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM399f89b37e22: [services] Tunnelbroker - Database MessageItem tests.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
test/
74 lines

Diff 11586

View Options

services/tunnelbroker/test/DatabaseManagerTest.cpp

Loading...