Details

Reviewers

Commits

rCOMMc093db50dc3b: [native] Introduce `ColorSelectorButton` component

Summary

First step in redesigning the ColorPicker component on native to match the ColorSelector component on web introduced by @atul.

ColorSelectorButton is a new component that will work with ColorSelector to replace ColorPicker on native.

See the full plan for the ColorPicker redesign in this Linear issue.

Test Plan

Tested on iOS 15.4 and works as expected:

Screen Shot 2022-04-20 at 10.27.59 AM.png (1×1 px, 593 KB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Apr 20 2022, 10:27 AM

Herald added subscribers: • benschac, • karol, • adrian and 2 others. · View Herald TranscriptApr 20 2022, 10:27 AM

• abosh edited the test plan for this revision. (Show Details)Apr 20 2022, 10:28 AM

• abosh added 1 blocking reviewer(s): atul.

• abosh edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B8356: Diff 11666.Apr 20 2022, 10:32 AM

• abosh requested review of this revision.Apr 20 2022, 10:32 AM

• abosh retitled this revision from [native] Redesign `native` `ColorPicker` component to [native] Introduce `ColorSelector` component.Apr 20 2022, 10:35 AM

• abosh edited the summary of this revision. (Show Details)

• abosh edited the summary of this revision. (Show Details)Apr 20 2022, 10:39 AM

Modify this diff to only include ColorSelectorButton.

• abosh retitled this revision from [native] Introduce `ColorSelector` component to [native] Introduce `ColorSelectorButton` component.Apr 20 2022, 4:50 PM

• abosh edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B8372: Diff 11684.Apr 20 2022, 4:54 PM

Memoized the backgroundColor style attribute for ColorSelectorButton.

Harbormaster completed remote builds in B8373: Diff 11685.Apr 20 2022, 5:29 PM

• abosh added a child revision: D3798: [native] Introduce `ColorSelector` component.Apr 20 2022, 5:35 PM

• abosh updated this revision to Diff 11688.Apr 20 2022, 7:50 PM

This comment was removed by • abosh.

Updated memoization to memoize array passed into style prop for the View in ColorSelectorButton.

Harbormaster completed remote builds in B8376: Diff 11688.Apr 20 2022, 7:55 PM

Harbormaster completed remote builds in B8377: Diff 11689.Apr 20 2022, 7:58 PM

In general we should avoid treating a diff as a scratchpad / space for iteration. If you put up a diff and realize that some changes are needed before it can be reviewed, you should remove it from your reviewer's queue using the "Plan Changes" action, and try to avoid updating it again until it's really ready for review. (If you end up needing to update it, but it's still not ready for review after the update, then you should hit "Plan Changes" again)

atul accepted this revision.Apr 24 2022, 2:18 PM

This revision is now accepted and ready to land.Apr 24 2022, 2:18 PM

atul added inline comments.Apr 24 2022, 2:18 PM