Paths

Table of Contentst

-
services/tunnelbroker/test/
-
tunnelbroker/
-
test/
-
DatabaseManagerTest.cpp

Differential D3689

[services] Tunnelbroker - Database MessageItem tests
ClosedPublic
Actions

Authored by • max on Apr 11 2022, 3:50 AM.

Tags

None

Referenced Files

	F5110410: D3689.id11701.diff
	Tue, Apr 1, 11:38 PM

	F5107162: D3689.id11581.diff
	Tue, Apr 1, 10:32 AM

	F5107139: D3689.id11544.diff
	Tue, Apr 1, 10:31 AM

	Unknown Object (File)
	Tue, Apr 1, 12:51 AM

	Unknown Object (File)
	Mon, Mar 31, 10:59 PM

	Unknown Object (File)
	Mon, Mar 31, 5:10 PM

	Unknown Object (File)
	Sun, Mar 30, 9:25 PM

	Unknown Object (File)
	Sat, Mar 29, 11:52 PM

Subscribers

Details

Reviewers

• karol
tomek
varun

Commits

rCOMM399f89b37e22: [services] Tunnelbroker - Database MessageItem tests

Summary

Database (DynamoDB) item tests. For the MessageItem database entity we perform:

Check if the table is available,
Create and fulfill database item entity,
Put into the database table,
Find the record using the primary key,
Compare record fields of created item and item from database record,
Remove the testing record from the database.

Related linear task: ENG-686

Test Plan

Run yarn test-tunnelbroker-service all tests are run and succeed.

Diff Detail

Repository

Branch

tunnelbroker-tests-database-messageitem

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Apr 11 2022, 3:50 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 11 2022, 3:50 AM

• max added reviewers: • karol, tomek, varun.Apr 11 2022, 3:50 AM

• max added a parent revision: D3643: [services] Tunnelbroker - Database item tests initialization.

• max mentioned this in D3643: [services] Tunnelbroker - Database item tests initialization.Apr 11 2022, 3:55 AM

Harbormaster completed remote builds in B8057: Diff 11276.Apr 11 2022, 3:55 AM

• max requested review of this revision.Apr 11 2022, 3:55 AM

We also need to clarify our approach to randomness in D3654

services/tunnelbroker/test/DatabaseManagerTest.cpp
43–48 ↗	(On Diff #11276)

This revision now requires changes to proceed.Apr 11 2022, 5:55 AM

Switch from memcmp to a simple EQ.

Switching to the Plan changes until we clarify the random/non-random value for tests.

Harbormaster completed remote builds in B8066: Diff 11285.Apr 11 2022, 6:31 AM

Added tests with static variables along with generated ones following D3654#102087.

Harbormaster completed remote builds in B8253: Diff 11544.Apr 18 2022, 6:22 AM

Verbose output for generated values was added.

Harbormaster completed remote builds in B8285: Diff 11581.Apr 18 2022, 11:53 PM

Remove == equality to EQ only.

Harbormaster completed remote builds in B8290: Diff 11586.Apr 19 2022, 12:57 AM

• max added 1 blocking reviewer(s): tomek.Apr 19 2022, 2:06 AM

tomek requested changes to this revision.Apr 19 2022, 2:35 AM

tomek added inline comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
26 ↗	(On Diff #11586)	We're testing db manager by putting a message item and checking if `find` returns a similar item - please update the test name

This revision now requires changes to proceed.Apr 19 2022, 2:35 AM

• max planned changes to this revision.Apr 20 2022, 12:40 PM

Changed the test names to reflect the actions inside.

• max marked an inline comment as done.Apr 21 2022, 1:28 AM

• max added inline comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
26 ↗	(On Diff #11586)	We're testing db manager by putting a message item and checking if `find` returns a similar item - please update the test name Agree, names were changed.

Harbormaster completed remote builds in B8389: Diff 11701.Apr 21 2022, 1:28 AM

tomek accepted this revision.Apr 21 2022, 2:37 AM

This revision is now accepted and ready to land.Apr 21 2022, 2:37 AM

Rebase on master.

Harbormaster completed remote builds in B8401: Diff 11720.Apr 21 2022, 4:51 AM

Closed by commit rCOMM399f89b37e22: [services] Tunnelbroker - Database MessageItem tests (authored by • max). · Explain WhyApr 21 2022, 4:53 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM399f89b37e22: [services] Tunnelbroker - Database MessageItem tests.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

test/

DatabaseManagerTest.cpp

74 lines

Diff 11720

services/tunnelbroker/test/DatabaseManagerTest.cpp

	// @flow			// @flow

	import type { ConnectionOptions, QueryResults, PoolOptions } from 'mysql';			import type { ConnectionOptions, QueryResults, PoolOptions } from 'mysql';
	import mysql from 'mysql2';			import mysql from 'mysql2';
	import mysqlPromise from 'mysql2/promise.js';			import mysqlPromise from 'mysql2/promise.js';
	import SQL from 'sql-template-strings';			import SQL from 'sql-template-strings';

	import { connectionLimit, queryWarnTime } from './consts.js';			import { connectionLimit, queryWarnTime } from './consts.js';
	import { getDBConfig } from './db-config.js';			import { getDBConfig } from './db-config.js';
	import DatabaseMonitor from './monitor.js';			import DatabaseMonitor from './monitor.js';
	import type { Pool, SQLOrString, SQLStatementType } from './types.js';			import type {
				Connection,
				Pool,
				SQLOrString,
				SQLStatementType,
				} from './types.js';
	import { getScriptContext } from '../scripts/script-context.js';			import { getScriptContext } from '../scripts/script-context.js';

	const SQLStatement: SQLStatementType = SQL.SQLStatement;			const SQLStatement: SQLStatementType = SQL.SQLStatement;

	let migrationConnection;			let migrationConnection;
	async function getMigrationConnection() {			async function getMigrationConnection() {
	if (migrationConnection) {			if (migrationConnection) {
	return migrationConnection;			return migrationConnection;
	▲ Show 20 Lines • Show All 159 Lines • ▼ Show 20 Lines		try {
	}			}
	}			}
	}			}

	function rawSQL(statement: SQLStatementType): string {			function rawSQL(statement: SQLStatementType): string {
	return mysql.format(statement.sql, statement.values);			return mysql.format(statement.sql, statement.values);
	}			}

	async function getMultipleStatementsConnection() {			async function getMultipleStatementsConnection(): Promise<Connection> {
	const { dbType, ...dbConfig } = await getDBConfig();			const { dbType, ...dbConfig } = await getDBConfig();
	const options: ConnectionOptions = {			const options: ConnectionOptions = {
	...dbConfig,			...dbConfig,
	multipleStatements: true,			multipleStatements: true,
	};			};
	return await mysqlPromise.createConnection(options);			return await mysqlPromise.createConnection(options);
	}			}

	export {			export {
	endPool,			endPool,
	SQL,			SQL,
	SQLStatement,			SQLStatement,
	appendSQLArray,			appendSQLArray,
	mergeAndConditions,			mergeAndConditions,
	mergeOrConditions,			mergeOrConditions,
	setConnectionContext,			setConnectionContext,
	dbQuery,			dbQuery,
	rawSQL,			rawSQL,
				getMultipleStatementsConnection,
	};			};