Paths

Table of Contentst

Differential D3859

[yarn] Bump `clang-format` to `1.7.0`
ClosedPublic
Actions

Authored by atul on Apr 27 2022, 8:12 AM.

Tags

None

Referenced Files

	F3239779: D3859.id11989.diff
	Wed, Nov 13, 10:44 AM

	F3239777: D3859.diff
	Wed, Nov 13, 10:44 AM

	Unknown Object (File)
	Sun, Nov 10, 12:51 AM

	Unknown Object (File)
	Fri, Nov 8, 10:05 AM

	Unknown Object (File)
	Fri, Nov 8, 10:04 AM

	Unknown Object (File)
	Oct 9 2024, 8:10 PM

	Unknown Object (File)
	Oct 9 2024, 8:10 PM

	Unknown Object (File)
	Oct 9 2024, 8:10 PM

Subscribers

Details

Reviewers

• jacek
tomek
ashoat

Commits

rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0`

Summary

Downstream dependencies have issues surfaced by yarn audit

The repo doesn't have release notes (that I could find), but looking at the commits since 1.5.0 they're all bumping deps and messing with CI

Depends on D3858

Test Plan

CI

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 27 2022, 8:12 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 27 2022, 8:12 AM

dedupe

Harbormaster completed remote builds in B8605: Diff 11989.Apr 27 2022, 8:17 AM

atul edited the summary of this revision. (Show Details)Apr 27 2022, 8:18 AM

atul added a parent revision: D3858: [keyserver] Bump `node-schedule` to `2.1.0`.

Harbormaster completed remote builds in B8606: Diff 11990.Apr 27 2022, 8:19 AM

atul requested review of this revision.Apr 27 2022, 8:19 AM

atul added a child revision: D3861: [keyserver] Bump `geoip-lite` to `1.4.5`.Apr 27 2022, 8:32 AM

atul added a child revision: D3860: [yarn] Bump transitive dependencies of `react-native-vector-icons`.Apr 27 2022, 8:45 AM

atul removed a child revision: D3861: [keyserver] Bump `geoip-lite` to `1.4.5`.

atul added a child revision: D3861: [keyserver] Bump `geoip-lite` to `1.4.5`.Apr 27 2022, 10:15 AM

Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future

At some point in the future we should move this to Nix

This revision is now accepted and ready to land.Apr 27 2022, 2:32 PM

Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future

Will do

At some point in the future we should move this to Nix

As in include clang-format binary directly instead of sourcing from npm package?

rebase before landing

In D3859#108122, @atul wrote:

At some point in the future we should move this to Nix

As in include clang-format binary directly instead of sourcing from npm package?

Yeah

Harbormaster completed remote builds in B8665: Diff 12062.Apr 28 2022, 12:10 PM

Closed by commit rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0` (authored by atul). · Explain WhyApr 28 2022, 12:22 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0`.

Revision Contents
Changeset List

Path

Size

2 lines

23 lines

Diff 12063

package.json

Loading...

yarn.lock

Loading...