Page MenuHomePhabricator

[yarn] Lift `.npmrc` up from `keyserver` to root of repo
ClosedPublic

Authored by atul on May 2 2022, 10:59 AM.
Tags
None
Referenced Files
F3361055: D3888.diff
Sun, Nov 24, 3:04 PM
Unknown Object (File)
Tue, Nov 19, 5:45 PM
Unknown Object (File)
Tue, Nov 19, 5:45 PM
Unknown Object (File)
Tue, Nov 19, 5:45 PM
Unknown Object (File)
Tue, Nov 19, 5:43 PM
Unknown Object (File)
Fri, Nov 15, 11:31 PM
Unknown Object (File)
Mon, Nov 11, 6:53 AM
Unknown Object (File)
Fri, Nov 8, 5:14 PM

Details

Summary

Addresses the issue with yarn upgrade-interactive documented by @benschac in ENG-1063: https://linear.app/comm/issue/ENG-1063/yarn-upgrade-interactive-functionality-errors

Basically, found that yarn upgrade-interactive failed in every yarn workspace except for keyserver. Was wondering what might be different, and remembered that we had to add an entry to keyserver/.npmrc in order for things to work there (https://phabricator.ashoat.com/D2966).

Tried moving .npmrc to the root of the repo and yarn upgrade-interactive worked fine without errors. I don't have much context on why we needed the .npmrc in the first place, but remember there was some weirdness with matrix/gitlab/etc... (would be good to get @marcinwasowicz's perspective here).

Test Plan
  1. Run yarn upgrade-interactive in the root of the repo.
  2. See if the yarn upgrade-interactive TUI shows up without displaying the "Can't find blah..." error message.

Did not actually try upgrading any packages with this interface. Will end up testing that implicitly the next time I upgrade a package (usually just modify package.json, but can use this approach just to make sure it works)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.May 2 2022, 11:05 AM
This revision is now accepted and ready to land.May 2 2022, 11:50 AM

Removing @marcinwasowicz as blocking reviewer since I think this is good to go and he's off for a few days, but would still be good for him to take a look.

I tried it.

It's working, but at a snails speed. It could just be my internet connection though.

It's working, but at a snails speed. It could just be my internet connection though.

It's slow for me as well on a pretty fast network:

44a6.png (830×1 px, 102 KB)

Guessing the dependency graph is just big or something