Page MenuHomePhabricator
Differential D4046

[web] Introduce `enum-settings-option[-info].css` stylesheets
ClosedPublic
Actions

Authored by atul on May 15 2022, 11:10 AM.
Tags
None
Referenced Files
F3383907: D4046.diff
Thu, Nov 28, 6:15 PM
Unknown Object (File)
Mon, Nov 25, 4:47 AM
Unknown Object (File)
Mon, Nov 25, 4:19 AM
Unknown Object (File)
Fri, Nov 15, 6:11 AM
Unknown Object (File)
Fri, Nov 15, 6:11 AM
Unknown Object (File)
Fri, Nov 15, 6:11 AM
Unknown Object (File)
Fri, Nov 15, 6:11 AM
Unknown Object (File)
Thu, Nov 14, 10:20 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• benschac
Commits
rCOMM02cca0a2e4fe: [web] Introduce `enum-settings-option[-info].css` stylesheets
Summary

Separating the styles for the NotificationsModal, EnumSettingsOption, and EnumSettingsOptionInfo components.

This diff works towards decoupling the EnumSettingsOption component from NotificationsModal... specifically so it can be re-used for the ThreadSettingsPrivacyTab component.

Depends on D4045

Test Plan

Close reading, opened NotificationsModal and it seemed to look/behave as expected:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 15 2022, 11:10 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 15 2022, 11:10 AM
atul published this revision for review.May 15 2022, 11:10 AM
atul edited the summary of this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
atul added a parent revision: D4045: [web] Rename `NotificationsOption` -> `EnumSettingsOption`.
Harbormaster completed remote builds in B9125: Diff 12690.May 15 2022, 11:14 AM
atul added a child revision: D4047: [web] Make `valid` prop of `EnumSettingsOptionInfo` optional.May 15 2022, 11:33 AM
tomek accepted this revision.May 17 2022, 6:10 AM
This revision is now accepted and ready to land.May 17 2022, 6:10 AM
atul updated this revision to Diff 12832.May 17 2022, 11:31 AM

rebase

This revision was landed with ongoing or failed builds.May 17 2022, 11:36 AM
Closed by commit rCOMM02cca0a2e4fe: [web] Introduce `enum-settings-option[-info].css` stylesheets (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM02cca0a2e4fe: [web] Introduce `enum-settings-option[-info].css` stylesheets.
Harbormaster completed remote builds in B9238: Diff 12832.May 17 2022, 11:37 AM

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
notifications/
14 lines
2 lines
enum-settings-option.css
notifications-modal.css
30 lines
2 lines
52 lines

Diff 12690

View Options

web/modals/threads/notifications/enum-settings-option-info.css

Loading...
View Options

web/modals/threads/notifications/enum-settings-option-info.react.js

Loading...
View Options

web/modals/threads/notifications/enum-settings-option.css

Loading...
View Options

web/modals/threads/notifications/enum-settings-option.react.js

Loading...
View Options

web/modals/threads/notifications/notifications-modal.css

Loading...