Page MenuHomePhabricator

[native] Update `sqlite3` entry to point to latest release
ClosedPublic

Authored by atul on May 16 2022, 6:34 AM.
Tags
None
Referenced Files
F3281456: D4055.id12808.diff
Sat, Nov 16, 9:44 AM
Unknown Object (File)
Fri, Nov 15, 6:11 AM
Unknown Object (File)
Thu, Nov 14, 10:22 AM
Unknown Object (File)
Thu, Nov 14, 10:22 AM
Unknown Object (File)
Thu, Nov 14, 10:22 AM
Unknown Object (File)
Thu, Nov 14, 10:22 AM
Unknown Object (File)
Wed, Nov 13, 10:51 AM
Unknown Object (File)
Wed, Nov 13, 10:51 AM

Details

Summary

Context: https://linear.app/comm/issue/ENG-373/update-sqlite3-entry-in-nativepackagejson-on-new-release

TLDR: the package wasn't being maintained and there hadn't been a release with the changes we needed... so we specified a commit here. now we can just point to the latest release which includes the changes we need.

Test Plan

CI

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.May 16 2022, 6:48 AM

remove sqlite3 from package.json altogether

it's a transitive dependency of @redux-devtools/cli

the only reason we were specifying it in package.json before was to override the latest release and point to a specific commit instead

yarn.lock
16231 ↗(On Diff #12740)

We can see that things are pointing to the right place here.

This revision is now accepted and ready to land.May 16 2022, 1:19 PM

review diff history before landing to make sure this matches