Differential D4043
[web] Move `ThreadSettingsModal` and related components to new `modals/threads/settings` directory Authored by atul on May 15 2022, 8:00 AM. Tags None Referenced Files
Details web/modals/threads was getting crowded by ThreadSettingsModal-related files... which are going to continue to grow in number. Created a new settings sub-directory in threads to consolidate the relevant files. Typically prefer to avoid heavily nested directory structure, but I think it makes sense here. Imports were "fixed" by my IDE/flow/eslint. Also opened ThreadSettingsModal in browser and clicked around making sure things appeared/worked as expected.
Diff Detail
Event TimelineComment Actions My only real comment here is, what do you think about getting rid of the -settings- in many of these file names? If they're in the settings folder now they're kind of redundant, no?
Comment Actions
Yeah that's a good point, the thread prefix is also probably redundant since the folder structure is like web/modals/threads/settings.. so just like delete-tab.react.js would work? That said, I still prefer the longer name since I tend to navigate by filename vs directory. Could also see it being confusing 5 years from now when we have a dozen general-tab.react.jss Comment Actions My preference is usually to avoid repeated path in file name, but at the same time, as you said, searching by filename is a big advantage of longer names. So it look like keeping the longer names is a better idea. | ||||||||||||||||||||||||||||||||||