Page MenuHomePhabricator

[services] Backup - Add Attachment Reactor Logic
ClosedPublic

Authored by karol on May 26 2022, 3:07 AM.
Tags
None
Referenced Files
F2174411: D4135.id13212.diff
Wed, Jul 3, 12:22 AM
F2170464: D4135.id13143.diff
Tue, Jul 2, 2:19 PM
Unknown Object (File)
Mon, Jul 1, 12:42 AM
Unknown Object (File)
Sun, Jun 30, 7:01 PM
Unknown Object (File)
Sun, Jun 30, 7:09 AM
Unknown Object (File)
Sun, Jun 30, 7:09 AM
Unknown Object (File)
Sun, Jun 30, 7:09 AM
Unknown Object (File)
Sun, Jun 30, 7:09 AM

Details

Summary

Depends on D4134

Adding AddAttachments logic. This is a Unary Reactor which means it goes only for one cycle, the response is empty, so it effectively just receives the data on the server and then returns a status.

logID is optional. If it's an empty string, the attachments are appended to the backup item.

Test Plan
  • terminal 1
cd services
yarn run-blob-service-dev-mode
  • terminal 2
cd services
yarn run-backup-service-dev-mode
  • terminal 3
git clone https://github.com/karol-bisztyga/grpc-playground.git
cd grpc-playground
git checkout backup-async
./build.sh
./cmake/build/bin/client
  • in terminal 3 create a new backup with n
  • check the database and see the empty string in attachmentHolders in the newly created item
  • add new attachments: in terminal 3 use b
  • check the database again and see new attachments in attachmentHolders in the newly created item
  • do a similar thing for the logs: first, use l and then k

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

karol edited the test plan for this revision. (Show Details)
karol added a reviewer: tomek.
This revision is now accepted and ready to land.May 27 2022, 6:03 AM
karol edited the summary of this revision. (Show Details)
karol edited the test plan for this revision. (Show Details)

update