Page MenuHomePhabricator
Differential D4428

[services] refactor subroutines to use new error types
ClosedPublic
Actions

Authored by varun on Jul 1 2022, 2:57 PM.
Tags
None
Referenced Files
F2207526: D4428.id14100.diff
Sun, Jul 7, 8:16 AM
F2207491: D4428.id14192.diff
Sun, Jul 7, 8:02 AM
F2205212: D4428.id14192.diff
Sat, Jul 6, 7:32 PM
F2204533: D4428.id14100.diff
Sat, Jul 6, 4:51 PM
F2204532: D4428.id.diff
Sat, Jul 6, 4:51 PM
Unknown Object (File)
Thu, Jul 4, 11:21 PM
Unknown Object (File)
Thu, Jul 4, 2:36 PM
Unknown Object (File)
Wed, Jul 3, 10:36 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
• jim
• karol
Commits
rCOMM9c4399076d70: [services] refactor subroutines to use new error types
Summary

we can now use the DBItemError type in the subroutines that handle parsing/unpacking DynamoDB attributes

Depends on D4427

Test Plan

printed out some of the errors to see how they're logged. cargo build + cargo run server

Diff Detail

Repository
rCOMM Comm
Branch
varun/improve-db-error-handling (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jul 1 2022, 2:57 PM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 1 2022, 2:57 PM
Harbormaster completed remote builds in B10216: Diff 14100.Jul 1 2022, 3:09 PM
varun requested review of this revision.Jul 1 2022, 3:09 PM
tomek accepted this revision.Jul 4 2022, 5:12 AM
tomek added inline comments.
services/identity/src/database.rs
57

Why do we remove an attribute here?

This revision is now accepted and ready to land.Jul 4 2022, 5:12 AM
varun added inline comments.Jul 5 2022, 7:39 AM
services/identity/src/database.rs
57

it's the same as get but it returns the actual value instead of a reference to it

Closed by commit rCOMM9c4399076d70: [services] refactor subroutines to use new error types (authored by varun). · Explain WhyJul 5 2022, 7:41 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM9c4399076d70: [services] refactor subroutines to use new error types.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
147 lines

Diff 14100

View Options

services/identity/src/database.rs

Loading...