Details

Reviewers

• max
• karol
ashoat
atul

Summary

Expose top-level for all cpp code

This is required since sqlite_orm is required by some CommonCpp projects

This is part of a larger effort to bring more structure to the C++ codebase https://linear.app/comm/issue/ENG-1310/export-nativecpp-projects-as-cmake-projects

The intent is to be able to reference the dependencies as packages, instead of just as GLOB'ing over certain directories; which is a major anti-pattern in CMake as it create a bunch of footguns such as finding multiple files with main() defined, or picking up unrelated code in generated folders.

Test Plan

nix develop
cd native/cpp/ && mkdir build && cd build && cmake .. && make
# should build everything in native/cpp

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jun 19 2022, 1:55 PM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 19 2022, 1:55 PM

• jon edited the summary of this revision. (Show Details)Jun 19 2022, 1:55 PM

• jon added a parent revision: D4300: [services] Export DatabaseManagers as CMake Project, normalize structure.

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 19 2022, 2:00 PM

Harbormaster failed remote builds in B9815: Diff 13579!

• jon added a child revision: D4302: [services] Export generated code as CMake Project.Jun 19 2022, 3:55 PM

Update with protobuf changes

Update diff dependency

• jon edited the summary of this revision. (Show Details)Jul 3 2022, 9:16 AM

• jon added a parent revision: D4431: [services] Export DatabaseManagers as CMake Project.

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2022, 9:21 AM

Harbormaster failed remote builds in B10230: Diff 14117!

Harbormaster failed remote builds in B10232: Diff 14119!

Lint

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 7 2022, 3:41 PM

Harbormaster failed remote builds in B10392: Diff 14302!

• jon requested review of this revision.Jul 7 2022, 3:43 PM

ashoat added inline comments.Jul 8 2022, 7:59 AM

native/cpp/CMakeLists.txt
3	A bit confused seeing this after the convo in ENG-1356. This `CMakeLists.txt` only get consumed for the Android build, right? How did we manage to get Android to cooperate with a newer version of CMake?

I think I did this work in anticipation of doing the android build "the right way" with imported targets. I decided later to drop that work.

However, I still like just doing add_subdirectory(../native/cpp) to import this from other areas in the code base.

So should we remove the comment? Still confused about the comment. Also not sure what CMP0079 is

This revision now requires changes to proceed.Jul 18 2022, 9:48 AM

Rebase with lint fixes

Harbormaster failed remote builds in B11316: Diff 15570!Aug 11 2022, 10:25 AM

native/cpp/CMakeLists.txt:12,02: [C0307] Bad indentation:
  )
^----BodyNode: 1:0->StatementNode: 9:0->TreeNode: 12:2

This revision now requires changes to proceed.Aug 11 2022, 10:30 AM

• jon removed a parent revision: D4300: [services] Export DatabaseManagers as CMake Project, normalize structure.Aug 12 2022, 4:17 PM

• jon planned changes to this revision.Aug 12 2022, 4:22 PM

• jon removed a child revision: D4302: [services] Export generated code as CMake Project.

• jon edited parent revisions, added: D4297: [services] Expose top-level CMakeList.txt for cpp projects; removed: D4431: [services] Export DatabaseManagers as CMake Project.Aug 16 2022, 5:03 PM

• jon edited the summary of this revision. (Show Details)Aug 18 2022, 11:00 AM

• jon edited the test plan for this revision. (Show Details)

Add top-level cpp CMake Project
Changes PlannedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 14302

native/cpp/CMakeLists.txt

Add top-level cpp CMake ProjectChanges PlannedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14302

native/cpp/CMakeLists.txt

Add top-level cpp CMake Project
Changes PlannedPublic
Actions

Revision Contents
Changeset List