Export the generated react-native NativeModules
as a CMake Project.
Generating the related files through CMake is a bit more involved,
so just present the generated files with a pretty bow.
Depends on D4301
Details
Details
nix develop && cd native/cpp/ && mkdir build && cd build && cmake .. && make
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Resigning since I'm usually not a good person to set as a first-pass reviewer. Exceptions here
Comment Actions
Not able to test this locally because I can't get nix to work at the moment, but it looks right to me.
Some of these CMakeLists.txt files assume that dependencies like gRPC and OpenSSL and whatever are available on the machine and can be found. This seems like a reasonable assumption when everything is under Nix, but could we include calls to FetchContent (https://cmake.org/cmake/help/latest/module/FetchContent.html) to fetch the dependencies in case they aren't on the machine to keep things more portable?
| native/cpp/CommonCpp/_generated/CMakeLists.txt | ||
|---|---|---|
| 18 | Can we add a little more detail here before landing? | |
Comment Actions
Some of these CMakeLists.txt files assume that dependencies like gRPC and OpenSSL and whatever are available on the machine and can be found. This seems like a reasonable assumption when everything is under Nix, but could we include calls to FetchContent (https://cmake.org/cmake/help/latest/module/FetchContent.html) to fetch the dependencies in case they aren't on the machine to keep things more portable?
Yea, that doesn't seem too unreasonable. But there is a long term maintenance burden with doing this, as there's a need to maintain two configuration which may be out-of-sync. However, falling back to pulling from a repo doesn't seem too bad. I can create a task to do so.
| native/cpp/CommonCpp/_generated/CMakeLists.txt | ||
|---|---|---|
| 18 | yea, I can expand | |
| native/cpp/CommonCpp/_generated/CMakeLists.txt | ||
|---|---|---|
| 26 | Line longer than 80 chars. See comment here and please prioritize resolving this with a CMake linter so I never have to leave a comment like this again | |