Export the generated react-native NativeModules
as a CMake Project.
Generating the related files through CMake is a bit more involved,
so just present the generated files with a pretty bow.
Depends on D4301
Differential D4302
[services] Export generated code as CMake Project • jon on Jun 19 2022, 3:55 PM. Authored by Tags None Referenced Files
Details Export the generated react-native NativeModules Generating the related files through CMake is a bit more involved, Depends on D4301 nix develop && cd native/cpp/ && mkdir build && cd build && cmake .. && make
Diff Detail
Event TimelineComment Actions Resigning since I'm usually not a good person to set as a first-pass reviewer. Exceptions here Comment Actions Not able to test this locally because I can't get nix to work at the moment, but it looks right to me. Some of these CMakeLists.txt files assume that dependencies like gRPC and OpenSSL and whatever are available on the machine and can be found. This seems like a reasonable assumption when everything is under Nix, but could we include calls to FetchContent (https://cmake.org/cmake/help/latest/module/FetchContent.html) to fetch the dependencies in case they aren't on the machine to keep things more portable?
Comment Actions
Yea, that doesn't seem too unreasonable. But there is a long term maintenance burden with doing this, as there's a need to maintain two configuration which may be out-of-sync. However, falling back to pulling from a repo doesn't seem too bad. I can create a task to do so.
|