Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Resigning since I'm usually not a good person to set as a first-pass reviewer. Exceptions here
Comment Actions
cd native/cpp && mkdir build && cd build && cmake .. && make
Running into
CMake Error at /opt/homebrew/lib/cmake/grpc/gRPCTargets.cmake:72 (set_target_properties): The link interface of target "gRPC::grpc" contains: OpenSSL::SSL but the target was not found. Possible reasons include: * There is a typo in the target name. * A find_package call is missing for an IMPORTED target. * An ALIAS target is missing. Call Stack (most recent call first): /opt/homebrew/lib/cmake/grpc/gRPCConfig.cmake:25 (include) CommonCpp/grpc/CMakeLists.txt:6 (find_package)
Is the assumption that this should be run within a nix shell? Can we use FetchContent here to make this build more portable?
Comment Actions
should be able to re-order this to not need this diff. Or if I do, it will look quite different