Page MenuHomePhabricator
Differential D4432

[nix] Add fbjni
AbandonedPublicDraft
Actions

Authored by • jon on Jul 3 2022, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 6:45 PM
Unknown Object (File)
Tue, Apr 8, 6:45 PM
Unknown Object (File)
Tue, Apr 8, 6:44 PM
Unknown Object (File)
Tue, Apr 8, 6:44 PM
Unknown Object (File)
Fri, Apr 4, 1:28 PM
Unknown Object (File)
Tue, Mar 25, 3:41 AM
Unknown Object (File)
Wed, Mar 19, 8:46 PM
Unknown Object (File)
Mar 16 2025, 6:12 PM
View All Files
Subscribers
• abosh
• adrian
atul
tomek

Details

Reviewers
varun
ashoat
Summary

Required by android build

Depends on D4302

Test Plan

Test plan is in the next diff, relating to the android fixes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 3 2022, 10:39 AM
Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptJul 3 2022, 10:40 AM
• jon added a child revision: D4433: [android] Fix android CI + build with CMake changes.Jul 3 2022, 10:42 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2022, 10:50 AM
Harbormaster failed remote builds in B10234: Diff 14123!
• jon updated this revision to Diff 14194.Jul 5 2022, 9:24 AM

Use upstream patch

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 5 2022, 9:28 AM
Harbormaster failed remote builds in B10296: Diff 14194!
• jon abandoned this revision.Jul 20 2022, 6:01 PM

Decided to upstream this, as the current android build doesn't make use of packages.

https://github.com/NixOS/nixpkgs/pull/182286

Revision Contents
Changeset List

PathSize
nix/
2 lines
47 lines
2 lines

Diff 14194

View Options

nix/dev-shell.nix

Show All 13 Lines
target_link_libraries(comm-client target_link_libraries(comm-client
comm-modules-native comm-modules-native
) )
target_link_libraries(comm-cryptotools target_link_libraries(comm-cryptotools
comm-tools comm-tools
comm-databasemanagers comm-databasemanagers
) )
target_link_libraries(comm-modules-internal
comm-tools
comm-client
)
target_link_libraries(comm-modules-native
comm-client
comm-cryptotools
comm-databasemanagers
comm-tools
)
target_link_libraries(comm-modules-persistentstorage
comm-databasemanagers
comm-client
)
View Options

nix/fbjni.nix

Show All 13 Lines
target_link_libraries(comm-client target_link_libraries(comm-client
comm-modules-native comm-modules-native
) )
target_link_libraries(comm-cryptotools target_link_libraries(comm-cryptotools
comm-tools comm-tools
comm-databasemanagers comm-databasemanagers
) )
target_link_libraries(comm-modules-internal
comm-tools
comm-client
)
target_link_libraries(comm-modules-native
comm-client
comm-cryptotools
comm-databasemanagers
comm-tools
)
target_link_libraries(comm-modules-persistentstorage
comm-databasemanagers
comm-client
)
View Options

nix/overlay.nix

Show All 13 Lines
target_link_libraries(comm-client target_link_libraries(comm-client
comm-modules-native comm-modules-native
) )
target_link_libraries(comm-cryptotools target_link_libraries(comm-cryptotools
comm-tools comm-tools
comm-databasemanagers comm-databasemanagers
) )
target_link_libraries(comm-modules-internal
comm-tools
comm-client
)
target_link_libraries(comm-modules-native
comm-client
comm-cryptotools
comm-databasemanagers
comm-tools
)
target_link_libraries(comm-modules-persistentstorage
comm-databasemanagers
comm-client
)