Page MenuHomePhabricator
Differential D4494

[Services] Update backup CMake
ClosedPublic
Actions

Authored by • jon on Jul 8 2022, 11:00 PM.
Tags
None
Referenced Files
F3521648: D4494.diff
Mon, Dec 23, 4:19 AM
F3521433: D4494.id15175.diff
Mon, Dec 23, 3:31 AM
Unknown Object (File)
Fri, Dec 20, 3:21 AM
Unknown Object (File)
Mon, Dec 16, 10:06 AM
Unknown Object (File)
Mon, Dec 16, 12:45 AM
Unknown Object (File)
Mon, Dec 16, 12:13 AM
Unknown Object (File)
Mon, Dec 16, 12:13 AM
Unknown Object (File)
Mon, Dec 16, 12:13 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
• max
tomek

Details

Reviewers
• max
• karol
atul
Commits
rCOMM682bd637b664: [Services] Update backup CMake
Summary

Make backup more nix friendly
Allow backup to be built outside of docker

Also moved Item.h to shared lib

Test Plan
nix develop
cd services/backup && mkdir build && cd build && cmake .. && make

docker workflow:

cd services/base-image
docker build -t commapp/services-base . -f Dockerfile

cd ../..
docker build . -f services/backup/Dockerfile

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jul 8 2022, 11:00 PM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 8 2022, 11:00 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 8 2022, 11:02 PM
Harbormaster failed remote builds in B10435: Diff 14379!
• jon updated this revision to Diff 14907.Jul 25 2022, 9:04 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 9:06 PM
Harbormaster failed remote builds in B10844: Diff 14907!
• jon added a parent revision: D4493: [Services] Update blob CMake project.Jul 26 2022, 8:24 AM
• jon updated this revision to Diff 15120.Jul 29 2022, 3:04 PM

Clean up backup cmake and docker build

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 3:05 PM
Harbormaster failed remote builds in B10986: Diff 15120!
• jon requested review of this revision.Jul 29 2022, 4:07 PM
• jon edited the test plan for this revision. (Show Details)
• jon added a reviewer: atul.
• jon retitled this revision from [Services] Export backup as CMake project to [Services] Update backup CMake.
• jon edited the summary of this revision. (Show Details)
atul accepted this revision.Aug 1 2022, 10:04 AM
cd services/base-image
docker build -t commapp/services-base . -f Dockerfile

cd ../..
docker build . -f services/backup/Dockerfile

Confirmed that this worked locally for me

This revision is now accepted and ready to land.Aug 1 2022, 10:04 AM
• jon updated this revision to Diff 15166.Aug 1 2022, 12:50 PM

Update base-image tag

Harbormaster failed remote builds in B11025: Diff 15166!Aug 1 2022, 12:51 PM
• jon updated this revision to Diff 15175.Aug 1 2022, 1:24 PM

rebase with lint fixes

Harbormaster completed remote builds in B11034: Diff 15175.Aug 1 2022, 1:37 PM
• jon mentioned this in D4492: [Services] Export server-base-reactors as CMake Project.Aug 3 2022, 7:35 PM
• jon mentioned this in D4491: [Services] Export client-base-reactors as CMake Project.Aug 3 2022, 7:39 PM
• jon mentioned this in D4671: [Services] Update tunnelbroker Dockerfile & cmake.Aug 3 2022, 10:05 PM
• jon mentioned this in D4489: [Services] Export shared services cpp as CMake Project.Aug 3 2022, 10:09 PM
• jon mentioned this in D4493: [Services] Update blob CMake project.
• jon mentioned this in D4302: [services] Export generated code as CMake Project.Aug 3 2022, 10:35 PM
• jon updated this revision to Diff 15297.Aug 3 2022, 11:23 PM

Rebase with fixes

Harbormaster completed remote builds in B11106: Diff 15297.Aug 3 2022, 11:37 PM
• jon added a child revision: D4735: [Services] Remove build_services compatibility logic.Aug 3 2022, 11:56 PM
• jon mentioned this in D4763: [Services] Allow backup to be built on MacOS.Aug 5 2022, 4:56 PM
• jon added a parent revision: D4763: [Services] Allow backup to be built on MacOS.Aug 5 2022, 4:56 PM
• jon updated this revision to Diff 15392.Aug 5 2022, 5:15 PM

Rebase with MacOS fixes

Harbormaster completed remote builds in B11185: Diff 15392.Aug 5 2022, 5:28 PM
• jon mentioned this in rCOMMfd098d391542: [Services] Export server-base-reactors as CMake Project.Aug 8 2022, 11:34 AM
• jon mentioned this in rCOMM1b61e233ae98: [Services] Export client-base-reactors as CMake Project.
• jon mentioned this in rCOMMe2e9907eb4fc: [Services] Update tunnelbroker Dockerfile & cmake.
• jon updated this revision to Diff 15441.Aug 8 2022, 11:42 AM

Merge MacOS fixes into this to ease review

Harbormaster completed remote builds in B11223: Diff 15441.Aug 8 2022, 11:56 AM
Closed by commit rCOMM682bd637b664: [Services] Update backup CMake (authored by • jon). · Explain WhyAug 8 2022, 1:45 PM
This revision was automatically updated to reflect the committed changes.
• jon mentioned this in rCOMM2d5c710211a1: [Services] Export shared services cpp as CMake Project.
• jon mentioned this in rCOMMc11d07fedc73: [Services] Update blob CMake project.
• jon added a commit: rCOMM682bd637b664: [Services] Update backup CMake.

Revision Contents
Changeset List

PathSize
services/
backup/
81 lines
14 lines
src/
4 lines
DatabaseEntities/
2 lines
Reactors/
client/
blob/
6 lines
server/
6 lines
grpc-client/
4 lines

Diff 15452

View Options

services/backup/CMakeLists.txt

Loading...
View Options

services/backup/Dockerfile

Loading...
View Options

services/backup/src/BackupServiceImpl.h

Loading...
View Options

services/backup/src/DatabaseEntities/DatabaseEntitiesTools.h

Loading...
View Options

services/backup/src/DatabaseManager.h

Loading...
View Options

services/backup/src/Reactors/client/blob/BlobGetClientReactor.h

Loading...
View Options

services/backup/src/Reactors/server/PullBackupReactor.h

Loading...
View Options

services/backup/src/grpc-client/ServiceBlobClient.h

Loading...