Clang is a bit more pedantic. Make it happy.
Occurred to me that this was never an existing workflow.
So I made it into another diff.
Allows for D4489 to be built from a MacOS device
Details
Details
Follow nix test plan from D4489 on a mac device
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/lib/src/ReactorStatusHolder.h | ||
|---|---|---|
| 25 ↗ | (On Diff #15387) | Could we do std::atomic<ReactorState> state{ReactorState::NONE};here?  |
| services/lib/src/ReactorStatusHolder.h | ||
|---|---|---|
| 25 ↗ | (On Diff #15387) | I'm not going to act like I know best practices in C++ cc @max Looks like they are equivalent: https://stackoverflow.com/questions/40378205/c-initialising-fields-directly-vs-initialisation-list-in-default-constructor |
| services/lib/src/ReactorStatusHolder.h | ||
|---|---|---|
| 25 ↗ | (On Diff #15387) | Gotcha, seems reasonable to leave as is Also don't know much C++, just been blindly following that braced initialization rule. |