Differential D4686

[Chore] Only checkout single-branch for grpc
ClosedPublic
Actions

Authored by • jon on Jul 29 2022, 3:15 PM.

Tags

None

Referenced Files

	F5932116: D4686.diff
	Fri, Apr 18, 5:07 AM

	Unknown Object (File)
	Thu, Apr 17, 12:30 AM

	Unknown Object (File)
	Tue, Apr 8, 8:59 PM

	Unknown Object (File)
	Tue, Apr 8, 8:59 PM

	Unknown Object (File)
	Tue, Apr 8, 8:59 PM

	Unknown Object (File)
	Tue, Apr 8, 8:59 PM

	Unknown Object (File)
	Wed, Apr 2, 12:15 AM

	Unknown Object (File)
	Sat, Mar 29, 9:31 PM

Subscribers

Details

Reviewers

Commits

rCOMM1fc6275ef78c: [Chore] Only checkout single-branch for grpc

Summary

Minimize how much we checkout for grpc

Test Plan

cd services/base-image
docker build .

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jul 29 2022, 3:15 PM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptJul 29 2022, 3:15 PM

• jon mentioned this in D4630: [Services] Install double and folly in base-image.Jul 29 2022, 3:16 PM

• jon added a child revision: D4630: [Services] Install double and folly in base-image.

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 3:17 PM

Harbormaster failed remote builds in B10988: Diff 15122!

Harbormaster completed remote builds in B10988: Diff 15122.Jul 29 2022, 4:06 PM

• jon requested review of this revision.Jul 29 2022, 4:06 PM

atul accepted this revision.Jul 30 2022, 10:02 AM

This revision is now accepted and ready to land.Jul 30 2022, 10:02 AM

Closed by commit rCOMM1fc6275ef78c: [Chore] Only checkout single-branch for grpc (authored by • jon). · Explain WhyAug 1 2022, 11:49 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM1fc6275ef78c: [Chore] Only checkout single-branch for grpc.

Revision Contents
Changeset List

Path

Size

services/

base-image/

docker/

install_grpc.sh

6 lines

Diff 15155

services/base-image/docker/install_grpc.sh

	#!/usr/bin/env bash			#!/usr/bin/env bash

	set -e			set -e

	# Allow scripts to be called from anywhere			# Allow scripts to be called from anywhere
	SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P)			SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P)

	# folly hack - https://github.com/facebook/folly/pull/1231			# folly hack - https://github.com/facebook/folly/pull/1231
	if [[ -f /usr/lib/folly/folly/detail/Demangle.h ]]; then
	# Legacy path-centric workflow
	sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
	/usr/lib/folly/folly/detail/Demangle.h
	rm -rf lib
	mkdir lib
	pushd lib
	ln -s /usr/lib/folly .
	ln -s /usr/lib/glog .
	ln -s /usr/lib/double-conversion .
	popd # lib

	rm -rf _generated
	mkdir _generated

	"${SCRIPT_DIR}"/proto_codegen.sh
	else
	# New installation centric workflow
	sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \			sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
	/usr/local/include/folly/detail/Demangle.h			/usr/local/include/folly/detail/Demangle.h
	fi

	rm -rf cmake/build			rm -rf cmake/build
	mkdir -p cmake/build			mkdir -p cmake/build

	"${SCRIPT_DIR}"/build_sources.sh			"${SCRIPT_DIR}"/build_sources.sh