[Services] Prune duplicated DatabaseEntitiesTools.h
AbandonedPublicDraft
Actions

Authored by • jon on Jul 29 2022, 4:19 PM.

Details

Reviewers

atul
• max
• karol

Summary

Blob, backup, and tunnelbroker all had a duplicated
DatabaseEntitiesTools.h. This prunes the duplicated file which was
added in D4489 to services/lib

Depends on D4489

Test Plan

Docker workflow:

cd services/base-image
docker build -t commapp/services-base . -f Dockerfile

cd ../..
docker build . -f services/tunnelbroker/Dockerfile

Before this is merged, base-image will need to be updated to reference
new docker hub image

Nix worfklow

nix develop
cd services/tunnelbroker
mkdir build && cd build && cmake .. && make

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 29 2022, 4:19 PM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptJul 29 2022, 4:19 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 4:20 PM

Harbormaster failed remote builds in B10991: Diff 15125!

Thinking more about this, I probably should just merge it into D4489 , as that that would fix the build without an intermediate commit

merged this into https://phab.comm.dev/D4489 to avoid a diff with more failing gates

• jon abandoned this revision.Aug 1 2022, 1:01 PM

• jon removed a child revision: D4493: [Services] Update blob CMake project.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Database/

DatabaseEntitiesTools.h

Diff 15125

View Options

services/tunnelbroker/src/Database/DatabaseEntitiesTools.h

This file was added.

				FROM commapp/services-base:1.1

				RUN apt-get update && \
				apt-get install -y uuid-dev && \
				rm -rf /var/lib/apt/lists/*

				ARG COMM_TEST_SERVICES
				ARG COMM_SERVICES_DEV_MODE

				ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
				ENV COMM_SERVICES_DEV_MODE=${COMM_SERVICES_DEV_MODE}

				WORKDIR /transferred

				COPY native/cpp/CommonCpp/grpc/protos/backup.proto native/cpp/CommonCpp/grpc/protos/blob.proto protos/
				COPY services/backup/docker/ scripts/
				COPY services/backup/ .

				RUN scripts/build_server.sh

				CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_server.sh; fi

[Services] Prune duplicated DatabaseEntitiesTools.hAbandonedPublicDraftActions