Page MenuHomePhabricator

[Services] Prune duplicated DatabaseEntitiesTools.h
AbandonedPublicDraft

Authored by jon on Jul 29 2022, 4:19 PM.
Tags
None
Referenced Files
F2829667: D4687.id15125.diff
Fri, Sep 27, 4:58 PM
F2829641: D4687.id.diff
Fri, Sep 27, 4:58 PM
F2829563: D4687.diff
Fri, Sep 27, 4:53 PM
Unknown Object (File)
Wed, Sep 25, 12:55 AM
Unknown Object (File)
Tue, Sep 24, 11:22 PM
Unknown Object (File)
Aug 28 2024, 4:33 PM
Unknown Object (File)
Aug 27 2024, 5:17 PM
Unknown Object (File)
Aug 23 2024, 3:12 AM

Details

Summary

Blob, backup, and tunnelbroker all had a duplicated
DatabaseEntitiesTools.h. This prunes the duplicated file which was
added in D4489 to services/lib

Depends on D4489

Test Plan
Docker workflow:

cd services/base-image
docker build -t commapp/services-base . -f Dockerfile

cd ../..
docker build . -f services/tunnelbroker/Dockerfile

Before this is merged, base-image will need to be updated to reference
new docker hub image

Nix worfklow

nix develop
cd services/tunnelbroker
mkdir build && cd build && cmake .. && make

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 4:20 PM
Harbormaster failed remote builds in B10991: Diff 15125!

Thinking more about this, I probably should just merge it into D4489 , as that that would fix the build without an intermediate commit