Page MenuHomePhabricator

[Services] Allow backup to be built on MacOS
AbandonedPublic

Authored by jon on Aug 5 2022, 4:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 4:19 AM
Unknown Object (File)
Fri, Sep 27, 4:18 AM
Unknown Object (File)
Fri, Sep 27, 4:15 AM
Unknown Object (File)
Tue, Sep 24, 11:28 PM
Unknown Object (File)
Tue, Sep 24, 11:28 PM
Unknown Object (File)
Tue, Sep 24, 11:28 PM
Unknown Object (File)
Sat, Aug 31, 12:02 AM
Unknown Object (File)
Fri, Aug 30, 8:27 PM

Details

Summary

Minor fixes to make MacOS happy when building with Clang

Test Plan

Follow nix test plan from D4494 on a MacOS device

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested changes to this revision.Aug 8 2022, 10:44 AM

Running into the following here:

atuls-MacBook-Pro:comm atul$ cd services/backup && mkdir build && cd build && cmake .. && make
-- The CXX compiler identification is AppleClang 13.1.6.13160021
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:19 (include):
  include could not find requested file:

    ./cmake-components/grpc.cmake


CMake Error at CMakeLists.txt:20 (include):
  include could not find requested file:

    ./cmake-components/folly.cmake


CMake Error at CMakeLists.txt:21 (add_subdirectory):
  add_subdirectory given source "./lib/glog" which is not an existing
  directory.


-- Found AWS SDK for C++, Version: 1.9.238, Install Root:, Platform Prefix:, Platform Dependent Libraries: pthread;curl
-- Components specified for AWSSDK: core;dynamodb, application will be depending on libs: aws-cpp-sdk-dynamodb;aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-core
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Found aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-dynamodb
-- Found aws-cpp-sdk-dynamodb
-- Found Boost: /nix/store/7rrgbk62knkpf4jngbrmzpjc002j2q65-boost-1.79.0-dev/lib/cmake/Boost-1.79.0/BoostConfig.cmake (found suitable version "1.79.0", minimum required is "1.40") found components: program_options 
-- Configuring incomplete, errors occurred!
See also "/Users/atul/comm/services/backup/build/CMakeFiles/CMakeOutput.log".
atuls-MacBook-Pro:build atul$
This revision now requires changes to proceed.Aug 8 2022, 10:44 AM

This is just the fixes for macOS specifically

D4494 has the changes needed to build it outside of docker

I just merged this into https://phab.comm.dev/D4494 to avoid reviewers having to checkout a later diff