Minor fixes for blob build to work with
Clang and MacOS
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Getting the following when I try the Nix test plan:
atuls-MacBook-Pro:comm atul$ cd services/blob && mkdir -p build && cd build && cmake .. && make
CMake Error at CMakeLists.txt:18 (include):
include could not find requested file:
./cmake-components/grpc.cmake
CMake Error at CMakeLists.txt:19 (include):
include could not find requested file:
./cmake-components/folly.cmake
CMake Error at CMakeLists.txt:20 (add_subdirectory):
add_subdirectory given source "./lib/glog" which is not an existing
directory.
-- Found AWS SDK for C++, Version: 1.9.238, Install Root:, Platform Prefix:, Platform Dependent Libraries: pthread;curl
-- Components specified for AWSSDK: s3;core;dynamodb, application will be depending on libs: aws-cpp-sdk-s3;aws-cpp-sdk-dynamodb;aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-core
-- Found aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-dynamodb
-- Found aws-cpp-sdk-dynamodb
-- Try finding aws-cpp-sdk-s3
-- Found aws-cpp-sdk-s3
-- Configuring incomplete, errors occurred!
See also "/Users/atul/comm/services/blob/build/CMakeFiles/CMakeOutput.log".Comment Actions
https://phab.comm.dev/D4493 has the cmake logic updated to be useful outside of docker. This diff was mac-specific changes.
https://phab.comm.dev/D4493 was rebased ontop of this work, so https://phab.comm.dev/D4493 should test both if you're running from a mac
Comment Actions
Getting the following:
atuls-MacBook-Pro:blob atul$ cd build && cmake .. && make
-- The C compiler identification is AppleClang 13.1.6.13160021
-- The CXX compiler identification is AppleClang 13.1.6.13160021
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:18 (include):
include could not find requested file:
./cmake-components/grpc.cmake
CMake Error at CMakeLists.txt:19 (include):
include could not find requested file:
./cmake-components/folly.cmake
CMake Error at CMakeLists.txt:20 (add_subdirectory):
add_subdirectory given source "./lib/glog" which is not an existing
directory.
-- Found AWS SDK for C++, Version: 1.9.238, Install Root:, Platform Prefix:, Platform Dependent Libraries: pthread;curl
-- Components specified for AWSSDK: s3;core;dynamodb, application will be depending on libs: aws-cpp-sdk-s3;aws-cpp-sdk-dynamodb;aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-core
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-dynamodb
-- Found aws-cpp-sdk-dynamodb
-- Try finding aws-cpp-sdk-s3
-- Found aws-cpp-sdk-s3
-- Found Boost: /nix/store/7rrgbk62knkpf4jngbrmzpjc002j2q65-boost-1.79.0-dev/lib/cmake/Boost-1.79.0/BoostConfig.cmake (found suitable version "1.79.0", minimum required is "1.40") found components: program_options
-- Found OpenSSL: /nix/store/1yhkn4rmhxpxdpvf10m10x5z60sxwhkr-openssl-1.1.1q/lib/libcrypto.dylib (found version "1.1.1q")
-- Configuring incomplete, errors occurred!
See also "/Users/atul/comm/services/blob/build/CMakeFiles/CMakeOutput.log".Comment Actions
I'll just merge these changes into https://phab.comm.dev/D4493. The diff here is applying the logic before the outside-of-docker logic is applied. So that's why your local runs are failing.
Comment Actions
Merged this into https://phab.comm.dev/D4493 to allow reviewers to checkout a diff with both MacOS and outside-of-docker fixes.